1053071 - Simplify EXTERNAL_SOURCE_DIR handling

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Simplify EXTERNAL_SOURCE_DIR handling

As handled in configure.in, EXTERNAL_SOURCE_DIR is a single directory for
external sources, and more specifically, comm-central. There is no need
to handle it as a list in the moz.build emitter.

At the same time, avoid checking the external sources for every moz.build,
and bind it to a config environment.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8472166 [details] [diff] [review]
Simplify EXTERNAL_SOURCE_DIR handling

Review of attachment 8472166 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/reader.py
@@ +181,5 @@
>              if filesystem_absolute:
>                  return path
> +            roots = [self.topsrcdir]
> +            if self.config.external_source_dir:
> +                roots += [self.config.external_source_dir]

Nit: The convention is |l.append(x)|, since += forces the creation of extra garbage.

Comment 3

[Mike Hommey [:glandium]]

Landed with a fixup in python/mozbuild/mozbuild/test/common.py for Windows tests.
https://hg.mozilla.org/integration/fx-team/rev/0ae7262449d8

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0ae7262449d8