1053080 - Improve mozbuild.util.memoize and add memoized_property

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Improve mozbuild.util.memoize and add memoized_property

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8472176 [details] [diff] [review]
Improve mozbuild.util.memoize and add memoized_property

Review of attachment 8472176 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/test/test_util.py
@@ +483,5 @@
> +        # same type should give us the same id.
> +        instance_id = id(instance)
> +        del instance
> +        instance = foo()
> +        self.assertEqual(instance_id, id(instance))

I /think/ this is a CPython implementation detail (objects are refcounted and destroyed immediately). Meh.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44b0dcb52a8c

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/44b0dcb52a8c