1053379 - Reduce amount of boilerplate code required for CodeAddressService

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Eric Rahm [:erahm]]

In bug 1050445 a fair amount of duplicated template params for CodeAddressService were added to BlockingResourceBase (copied from nsTraceRefcnt). We can probably either factor these out to a shared header or add sensible defaults to CodeAddressService itself.

It seems like for CodeAddressService we could reduce the amount of template params to:
  - writer
  - allocator
  - unlocker

The hashtable param could just be replaced w/ the standard implementation we have now and the allocator provided as a template param would be used.

We could go further and provide sensible defaults for allocator and unlocker and DMD could override those. So in theory a standard implementation would just look like this:

  struct MyWriter { ... };
  CodeAddressService<MyWriter> cas;

Comment 1

[Andrew McCreight [:mccr8]]

That sounds like a good idea.  The parameters are basically needed because DMD is weird.  I expect every usage in the browser itself will just use the standard set of arguments.

Comment 2

[Nicholas Nethercote [inactive]]

Bug 1061385 removed the |Writer| param, which was a big part of this.

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1053379 - Simplify CodeAddressService so non-DMD users can rely on defaults.

None of the StringTable implementations were freeing their strdup'd
strings, either.

Comment 4

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc75e3af89d0a7c24942c9d8d492b0badbeacaa3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6411cd0771a9
Simplify CodeAddressService so non-DMD users can rely on defaults. r=njn

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6411cd0771a9