1053468 - when setting breakpoint, only resume if actually interrupted

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[James Long (:jlongster)]

In `setBreakpoint` in dbg-client.jsm, we resume the thread if we had to interrupt it to set the breakpoint. The `resume` called at the end of the function should only happen if the pause type is "interrupt". There's probably a race condition in there so we should add the check for good measure.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Good idea.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: bp-interrupt.patch

Unfortunately, I wasn't able to write a failing test. I was able to write a test that printed out an error message when we hit the race, but I couldn't create an assertion that failed with the error message. Either way, this change made the error message go away.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=993df2622b70

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: non-failing-test-case.patch

For posterity, this is the test case that I could get an error message to be printed without the previous patch applied, but couldn't get it to actually fail any assertions.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/2498263e8cf7

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2498263e8cf7