Closed
Bug 1053468
Opened 10 years ago
Closed 10 years ago
when setting breakpoint, only resume if actually interrupted
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: jlong, Assigned: fitzgen)
Details
Attachments
(2 files)
1.11 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
1.88 KB,
patch
|
Details | Diff | Splinter Review |
In `setBreakpoint` in dbg-client.jsm, we resume the thread if we had to interrupt it to set the breakpoint. The `resume` called at the end of the function should only happen if the pause type is "interrupt". There's probably a race condition in there so we should add the check for good measure.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → jlong
Comment 1•10 years ago
|
||
Good idea.
Assignee | ||
Comment 2•10 years ago
|
||
Unfortunately, I wasn't able to write a failing test. I was able to write a test that printed out an error message when we hit the race, but I couldn't create an assertion that failed with the error message. Either way, this change made the error message go away. Try push: https://tbpl.mozilla.org/?tree=Try&rev=993df2622b70
Assignee | ||
Comment 3•10 years ago
|
||
For posterity, this is the test case that I could get an error message to be printed without the previous patch applied, but couldn't get it to actually fail any assertions.
Updated•10 years ago
|
Attachment #8479270 -
Flags: review?(past) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2498263e8cf7
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2498263e8cf7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Updated•10 years ago
|
QA Whiteboard: [qa-]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•