1053812 - [Homescreen] [SingleVariant] SV Apps are installed at the end of the grid instead of on their valid positions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Carmen Jimenez Cabezas]

STR:

1. Prepare a build with single variant apps, and define specific positions for those apps.
2. Boot with a configured SIM inserted

Expected:
Apps appear on their configured positions

Actual:
Randomly (sometimes, it doesn't happen always) single variant apps appear at the end of the grid.
The problem happens when the apps are installed before the homescreen app is launched (it's more probable to happen if the SIM inserted doesn't have a PIN set)

Comment 1

[Carmen Jimenez Cabezas]

Attachment: V1 Proposed patch

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8473059 [details] [review]
V1 Proposed patch

So I took a look at the code, and it generally looks fine to me. It does seem quite complex though. Without tests, and probably marionette tests, I fear that this could probably break. Though being that this issue was intermittent, I'm not sure how much a marionette test could help here.

Comment 3

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/gaia/commit/a3423431fad131396009eb4f2742bb72f19edf89