1053882 - Remove GrallocTextureHostOGL::ForgetSharedData()

Status: RESOLVED INVALID

(Core :: Graphics: Layers, defect)

Description

[Sotaro Ikeda [:sotaro]]

GrallocTextureHostOGL::ForgetSharedData() is not necessary for gralloc buffer.

ForgetSharedData() needs to be implemented when there is a case that an actual buffer needs to be deleted by client side since TextureHost is created. gralloc buffer does not have such necessity.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove GrallocTextureHostOGL::ForgetSharedData()

Comment 2

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> GrallocTextureHostOGL::ForgetSharedData() is not necessary for gralloc
> buffer.
> 
> ForgetSharedData() needs to be implemented when there is a case that an
> actual buffer needs to be deleted by client side since TextureHost is
> created. gralloc buffer does not have such necessity.

"gralloc buffer does not have such necessity." paret was wrong.
When TextureFlags::DEALLOCATE_CLIENT flag is set, gralloc texture release is triggered from client side. But there is still no necessity to implement ForgetSharedData().

Comment 3

[Sotaro Ikeda [:sotaro]]

I changed my mind. It seems better not to remove ForgetSharedData(). Instead, it seems better to implement it correctly. current implementation is not correct.