Closed
Bug 1053901
Opened 10 years ago
Closed 10 years ago
Change the wiki profile URL to optional
Categories
(Mozilla Reps Graveyard :: reps.mozilla.org, task)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: williamr, Assigned: nikos, Mentored)
Details
(Whiteboard: [kb=1472690] [good first bug])
On Reps profiles, there is a field for Wiki Profile URL that is required. It no longer needs to be required since all activities are now documented on the Reps Portal. Let's keep the field and make it optional.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [good first bug] → [kb=1472690] [good first bug]
Updated•10 years ago
|
Mentor: jgiannelos
Updated•10 years ago
|
Assignee: nobody → bkerensa
Comment 2•10 years ago
|
||
Hey :bkerensa, I've added a couple of comments to your PR. Thank you for the contribution!
Comment 3•10 years ago
|
||
Is the task complete?
Comment 4•10 years ago
|
||
@John after modifying the URLField(blank=True), does that regex validation requires?
Updated•10 years ago
|
Assignee: bkerensa → nobody
Updated•10 years ago
|
Assignee: nobody → comzeradd
Status: NEW → ASSIGNED
Comment 5•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/remo https://github.com/mozilla/remo/commit/23da85354f45fc1a34c9fad94104fe5e17de4949 [fix bug 1053901] Change the wiki profile URL to optional https://github.com/mozilla/remo/commit/698f9c3ab03cc0d1c177a87347428d8495cddfab Merge pull request #875 from comzeradd/wiki-profile-url [fix bug 1053901] Change the wiki profile URL to optional
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Version: unspecified → next
Comment 6•10 years ago
|
||
Verified on stage. Steps: * Empty wiki profile in this account: https://reps.allizom.org/u/akatsoulas * Profiles is saved normally. * No wiki profile is displayed * When editing the profile the required mark (*) is missing. Thanks :cocomzeradd!
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Version: next → 446
Updated•4 years ago
|
Product: Mozilla Reps → Mozilla Reps Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•