1053985 - [Meta] Improve UX of the repos menu/panel

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Umbrella bug for various usability improvements to the repo panel/menu. We don't need to fix all of these before calling this bug fixed-enough that is is no longer a blocker - but a proportion of them would be great.

Comment 1

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #0)
> Umbrella bug for various usability improvements to the repo panel/menu. We
> don't need to fix all of these before calling this bug fixed-enough that is
> is no longer a blocker - but a proportion of them would be great.

Just to emphasis the "we don't need to fix all dependants of this". ie: this bug can be marked as resolved fixed even before all dependant bugs are fixed, and thus no longer be blocking bug 1030636 even when only X % of them are fixed. Prioritising dependants of this can be done using the "priority" field and/or discussion in this bug.

Comment 2

[Ed Morley [:emorley]]

Breaking out from bug 1045618:

For TBPL, the repo menu (/more recently used items that are broken out of the menu) serves two purposes (for me at least):
A) Switching the current tab to another repo
B) Allowing me to open new tabs for one or more other repos, leaving the current tab unchanged.

I'd say use-case #B is the most common for me, since I often have pinned app-tabs for the main repos I look at - and then occasionally need to load an extra one to glance at temporarily during the day.

The simplicity of the TBPL menu works well for both of the above use-cases, since:
1) All repos can be seen on the menu at the same time, without having to scroll up-down
2) Clicking away from the menu closes it, such that the "open menu, middle mouse click 3 other repos to open in new tabs, click away from menu to close it" workflow is pretty painless.
3) The repos menu isn't too large, so it's easy to click away from the menu (see #2).
4) The repos are in some sort of sensible order (whilst there aren't actual groups, the order allows for psuedo-visual grouping).
5) A single column of repo names is easier to skim read than split columns.

Now ok treeherder adds more functionality to the repos menu (namely the "tree info" type items) and we display more repos than in TBPL (since we now support more projects than just those run in buildbot) - so the TBPL design might not work as-is any more - but I still think we can come up with a mixture of the TBPL & treeherder UX that gives the best of both.

Comment 3

[William Lachance (:wlach)]

We've decided to just take out the tabs and make it so selecting an option in the repos panel just switches the view to that repository. Work is being tracked in bug 1062535. This will magically fix many of the issues attached to this meta bug.

Comment 4

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #3)
> We've decided to just take out the tabs and make it so selecting an option
> in the repos panel just switches the view to that repository. Work is being
> tracked in bug 1062535. This will magically fix many of the issues attached
> to this meta bug.

Nope, we've gone back on this decision. Instead, we're going to make switch tabs work more like tbpl, where the entire view is reloaded.

Comment 5

[Cameron Dawson [:camd]]

We've change this decisions yet again!  Here at the workweek, we discussed it with the sheriffs and they really just want a drop-down menu that's grouped by repo category.

Comment 6

[Ed Morley [:emorley]]

https://github.com/mozilla/treeherder-ui/commit/1ac87534a44c7ff5e8ae000752cb878800e9b272

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b30841370c4858d24a0edad1d0294ffa55ad08cb
bug 1053985 - fixes most of the dependent bugs