Closed Bug 1054129 Opened 10 years ago Closed 9 years ago

Set options.success automatically in sendChromeMessage()

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 991582

People

(Reporter: aknow, Assigned: aknow)

References

Details

Attachments

(1 file)

I am thinking of setting |options.success| automatically in sendChromeMessage() of ril_worker. That means we don't have to explicitly set it to true or false. The value always depends on whether the object contains an |errorMsg|. By this way --
1. All the messages without errorMsg are successful.
2. If the message is not successful, it guarantees that there is an |errorMsg| showing the details.
Assignee: nobody → szchen
Attachment #8473459 - Flags: feedback?(htsai)
Comment on attachment 8473459 [details] [diff] [review]
0001-set-options.success-automatically.patch

Review of attachment 8473459 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!
Attachment #8473459 - Flags: feedback?(htsai) → feedback+
See Also: → 991582
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: