1054209 - _attachments path broken after staticfiles migration

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Yohan Boniface [:ybon]]

Users trying to download an addon from Thunderbird have a 404 since last push.

The reason is that Thunderbird goes through the '_attachments' path, which has a dedicated URL rule.

And we missed this one on the push.

Here is an example of URL going in 404:

https://addons.cdn.mozilla.net/user-media/addons/_attachments/54035/thunderbird_conversations-2.8.1-tb.xpi

And this is the fix we need, on this line (and two lines after):

https://github.com/mozilla-services/svcops-puppet/blob/master/modules/marketplace/templates/nginx/addons.conf#L43

change '_files/_attachments' to 'addons/_attachments'

Comment 1

[Yohan Boniface [:ybon]]

Note: I don't know why we add the 'Content-Disposition: attachment' header, I guess it's needed by Thunderbird.

In the case we think this is not anymore needed, we can then instead change in the code that we don't need that '_attachments' path anymore, and remove the dedicated URL rule. But I honestly don't know who can know that, so I think we should keep the path as it is.

Comment 2

[Onno Ekker [:nONoNonO UTC+1]]

The Content-Disposition: attachment header is, so that Thunderbird downloads are getting downloaded when you click the download button in Firefox. If you don't have that header, Firefox tries to install the xpi.

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

Hmm, maybe not exact duplicates but more depending on this bug...

Comment 7

[Yohan Boniface [:ybon]]

I think duplicate it's fine, there is no specific action required on the other bugs other than the one here.

Thanks!

Comment 8

[Yohan Boniface [:ybon]]

Fix has been pushed https://github.com/mozilla-services/svcops-puppet/commit/e6703bc93693f51923ca4af843cfa2a36de10361