Closed Bug 1054642 Opened 10 years ago Closed 10 years ago

quoteUrls() enters an infinite loop with a list of nonexistent bug ids to be linkified

Categories

(Bugzilla :: Bugzilla-General, defect)

4.5.5
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 5.0

People

(Reporter: koosha.khajeh, Assigned: koosha.khajeh)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 213440 introduced linkification of a list of bug ids. If a list of nonexistent bug ids is in a comment, the 'while' loop will run forever because the string undergoes no change.

This is not the case with a list of nonexistent comment ids but we can change its code to be safer in future and to look more concise.
Attachment #8474100 - Flags: review?(glob)
Assignee: general → koosha.khajeh
Comment on attachment 8474100 [details] [diff] [review]
patch

Review of attachment 8474100 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob
Attachment #8474100 - Flags: review?(glob) → review+
Flags: approval?
Target Milestone: --- → Bugzilla 5.0
Flags: approval? → approval+
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   dfcf306..0922b44  master -> master
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 213440
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: