1055113 - netwerk/ipc/RemoteOpenFileChild.cpp:84:68: error: 'dup' was not declared in this scope

Status: RESOLVED FIXED

(Core :: Networking: File, defect)

Description

[Jan Beich]

It doesn't happen with unified build because NeckoParent.cpp in the same compilation unit pulls <unistd.h> from FileUtils.h (via ContentParent.h).

netwerk/ipc/RemoteOpenFileChild.cpp:84:19: error: use of undeclared identifier 'dup'
    PROsfd osfd = dup(PR_FileDesc2NativeHandle(other.mNSPRFileDesc));
                  ^
netwerk/ipc/RemoteOpenFileChild.cpp:393:17: error: use of undeclared identifier 'dup'
  PROsfd osfd = dup(PR_FileDesc2NativeHandle(mNSPRFileDesc));
                ^

Comment 1

[Jan Beich]

full build log - http://buildbot.rhaalovely.net/builders/mozilla-aurora-freebsd-amd64/builds/393/steps/build/logs/stdio

Comment 2

[Jan Beich]

Attachment: fix

Explicitly add unistd.h like in RemoteOpenFileParent.cpp.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a290add459d9

Comment 3

[Jan Beich]

Comment on attachment 8474703 [details] [diff] [review]
fix

Approval Request Comment
[Feature/regressing bug #]: bug 988816 regression
[User impact if declined]: broken build on at least FreeBSD without --enable-unified-compilation
[Describe test coverage new/current, TBPL]: soon
[Risks and why]: Low, broken build at most.
[String/UUID change made/needed]: None

Comment 4

[Shian-Yow Wu [:swu]]

Comment on attachment 8474703 [details] [diff] [review]
fix

Review of attachment 8474703 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.  It looks good to me, and I think we also need it get signed by Jason.

Comment 5

[Jan Beich]

(In reply to Jan Beich from comment #2)
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a290add459d9
> gfx/thebes/gfxPattern.cpp:61:13: error: 'Filter' is not a class, namespace, or enumeration

Oops, unrelated red due to bug 1053159. Trying again with fresh m-i changes.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=aec5ea0efe64

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb91698edd20

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb91698edd20

Comment 8

[Sylvestre Ledru [:Sylvestre]]

approval-mozilla-aurora+ is enough to get the sheriff attention ;)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a79033353ab9