Closed
Bug 1055408
Opened 10 years ago
Closed 10 years ago
[EME] Kill GMP timers when entering shutdown
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.71 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
We need to cancel the GMPTimers when we start to shutdown a GMP process, otherwise the timers can fire after the IPC bridge has shutdown, and if a timer fires and tries to notify the GMP process Bad Things will happen.
Assignee | ||
Comment 1•10 years ago
|
||
This is based on top of my patch for bug 1034368 (GMPStorage).
Attachment #8474963 -
Flags: review?(rjesup)
Comment 2•10 years ago
|
||
Comment on attachment 8474963 [details] [diff] [review] Patch Review of attachment 8474963 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/gmp/GMPParent.cpp @@ +246,5 @@ > mAudioDecoders[i - 1]->Shutdown(); > } > > + // Note: we don't shutdown timers here, we do that in CloseIfUnused(), > + // as there is multiple entry points to CloseIfUnused(). there are
Attachment #8474963 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b0d1e17cad0
Comment 4•10 years ago
|
||
Backed out this and the parent patch (I can't see the bug) for bustage. https://hg.mozilla.org/integration/mozilla-inbound/rev/1db9d4b9d740 https://hg.mozilla.org/integration/mozilla-inbound/rev/4dc129c1aef4
Assignee | ||
Comment 5•10 years ago
|
||
Re-landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/198c0704bacc
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/198c0704bacc
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•