1055643 - System JS : WARNING resource://services-crypto/utils.js:396 - variable value redeclares argument

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Daniel Holbert [:dholbert]]

I noticed this warning early on during a mochitest run:
{
12 INFO System JS : WARNING resource://services-crypto/utils.js:396 - variable value redeclares argument
}

Relevant source code:
> 395   stripHeaderAttributes: function(value) {
> 396     let value = value || "";

http://mxr.mozilla.org/mozilla-central/source/services/crypto/modules/utils.js?rev=6e77dfcf5c6e&mark=395-396#395

We just want to drop the "let" there, I think.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Chris Karlof [:ckarlof]]

Thanks!

Comment 3

[Daniel Holbert [:dholbert]]

Thanks for the review! Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/ecc9477045c7

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ecc9477045c7

Comment 5

[:Gavin Sharp [email: [e-mail]]]

FWIW this probably bitrotted one of the patches in bug 1001090.