1055777 - enable spot instances for some release builders

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

Good candidates are:

update verify, final verify (read-only builders)
xulrunner builders

Maybe linux builds (not l10n repacks) too - they are not in critical path and almost idempotent.

Comment 1

[Rail Aliiev [:rail]]

Attachment: spot.diff

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8475508 [details] [diff] [review]
spot.diff

Review of attachment 8475508 [details] [diff] [review]:
-----------------------------------------------------------------

x

::: process/release.py
@@ -1060,1 @@
>                  'env': builder_env,

Partner repacks all happen on Mac anyways, but this is fine.

@@ -1439,5 @@
>              'builddir': builderPrefix('postrelease'),
>              'slavebuilddir': normalizeName(builderPrefix('postrelease'), releaseConfig['productName']),
>              'factory': postrelease_factory,
>              'env': builder_env,
> -            'nextSlave': _nextSlave_skip_spot,

I don't think this is safely re-runnable. updateSymlink could fail, and maybe the bouncer alias'?

Comment 3

[Rail Aliiev [:rail]]

Attachment: spot2.diff

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8475942 [details] [diff] [review]
spot2.diff

https://hg.mozilla.org/build/buildbotcustom/rev/438cd157a2b2

Comment 5

[Jordan Lund (:jlund)]

buildbotcustom patch live in production