Closed
Bug 1055820
Opened 10 years ago
Closed 10 years ago
Build error due to GetVersionExW being deprecated in VS2013
Categories
(Core :: Security, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1055541
People
(Reporter: cpearce, Assigned: cpearce)
Details
Attachments
(1 file)
1.35 KB,
patch
|
Details | Diff | Splinter Review |
I'm getting a build error on Windows 8.1 with m-c tip and warings-as-errors on: 1:42.04 c:/Users/cpearce/src/mozilla/purple/security/sandbox/chromium/base/win/windows_version.cc(37) : error C2220: warning treated as error - no 'object' file generated 1:42.04 Warning: C4996 in c:\Users\cpearce\src\mozilla\purple\security\sandbox\chromium\base\win\windows_version.cc: 'GetVersionExW': was declared deprecated 1:42.04 c:/Users/cpearce/src/mozilla/purple/security/sandbox/chromium/base/win/windows_version.cc(37) : warning C4996: 'GetVersionExW': was declared deprecated 1:42.04 C:\Program Files (x86)\Windows Kits\8.1\Include\um\sysinfoapi.h(442) : see declaration of 'GetVersionExW' This is similar to Bug 892859; GetVersionExW is deprecated with the Win8.1 SDK installed, I think I have that because it comes with Visual Studio 2013 which I have installed too.
Assignee | ||
Comment 1•10 years ago
|
||
Suppress warning 4996 in Windows sandbox.
Comment 2•10 years ago
|
||
We should not be modifying code that came from upstream.
Assignee | ||
Comment 3•10 years ago
|
||
OK. How should we prevent this error? Disable warnings-as-errors on this directory? Or can we add a compile time option on Windows to disable this warning?
Comment 4•10 years ago
|
||
(In reply to Chris Pearce (:cpearce) from comment #3) > OK. How should we prevent this error? Disable warnings-as-errors on this > directory? Or can we add a compile time option on Windows to disable this > warning? The latter.
Comment 5•10 years ago
|
||
Comment on attachment 8475507 [details] [diff] [review] 1055820-sandbox-wae.patch Review of attachment 8475507 [details] [diff] [review]: ----------------------------------------------------------------- Dropping review per above.
Attachment #8475507 -
Flags: review?(ted)
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•