1056581 - Sunspider-regexp-dna takes 107% more time on windows

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

When running ss-regexp-dna with --no-ion I get the following difference on Windows/Linux (on the same computer):

Windows: 29ms
Linux: 14ms

I can only assume it can be related to two things.
1) Concat of strings is slower on windows?
2) The regexp could get transformed into string matching on which linux has a superiour memchr.

Comment 1

[Hannes Verschore [:h4writer]]

Ok, this is a windows-shell only problem. Apparently the "load()" js function is very unoptimized on windows. In the browser this isn't a problem, since we don't have/use "load". Though in the shell builds we do.

This also explains the discrepancy viewed on AWFY:
http://arewefastyet.com/#machine=17&view=single&suite=ss&subtest=dna&start=1407832202&end=1407915344

Comment 2

[Hannes Verschore [:h4writer]]

Attachment: Check if having _getc_nolock

Apparently we aren't using the fast call _getc_nolock anymore, since we are skipping compiler and library checks.

This fixes the seen issue.

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 8477615 [details] [diff] [review]
Check if having _getc_nolock

Review of attachment 8477615 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.

Incidentally, in English, "seen" cannot modify a noun attributively. I don't know why. There seems to be no general rule.

    a/the known [noun]      -  756 hits in http://corpus.byu.edu/coca/
    a/the broken [noun]     - 2811
    a/the written [noun]    - 2036
    a/the observed [noun]   -  622
    a/the seen [noun]       -   16, all weird

What's really crazy is that "unseen" is used this way:

    a/the unseen [noun]     -  199 (!)

Comment 4

[Hannes Verschore [:h4writer]]

Oh I had no idea. Thanks for the explanation.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2eda589ea8d

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2eda589ea8d