1056587 - [mozlog] Be less verbose in TBPL Formatter when a test was expected to PASS

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[James Graham [:jgraham]]

In the case of TEST-UNEXPECTED-* we currently always print a line containing

TEST-INFO expected STATUS

For many testsuites, STATUS will always be PASS, so this is regarded as noise. For cases where it isn't e.g. w-p-t it might be OK to regard PASS as the default and only print the expected status if it's something different (obviously we'll have to see if this is itself confusing).

Comment 1

[James Graham [:jgraham]]

Attachment: Only print line with expected status in tbpl logs when this isn't PASS

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8476537 [details] [diff] [review]
Only print line with expected status in tbpl logs when this isn't PASS

Review of attachment 8476537 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozlog/mozlog/structured/formatters/tbplformatter.py
@@ +79,1 @@
>              return "\n".join([failure_line, info_line])

info_line is not always defined now.

Comment 3

[James Graham [:jgraham]]

Attachment: Only print line with expected status in tbpl logs when this isn't PASS

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8476717 [details] [diff] [review]
Only print line with expected status in tbpl logs when this isn't PASS

Review of attachment 8476717 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozbase/mozlog/mozlog/structured/formatters/tbplformatter.py
@@ +77,5 @@
> +            if data["expected"] != "PASS":
> +                info_line = "TEST-INFO | expected %s\n" % data["expected"]
> +                return "\n".join([failure_line, info_line])
> +            else:
> +                return failure_line

"don't put else right after a return" is in the style guide somewhere.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

bug 1055679 might have a change on inbound that conflicts with this, sorry about that.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7c7f9d25fe38