Closed
Bug 1057006
Opened 10 years ago
Closed 10 years ago
Implement UI for app sharing
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: florian, Assigned: florian)
References
(Depends on 1 open bug)
Details
Attachments
(2 files, 5 obsolete files)
5.89 KB,
patch
|
jib
:
review+
|
Details | Diff | Splinter Review |
22.75 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 1036653 does the strict minimum in browser/ for app sharing to work, but we need to implement the UX designed in bug 1053221.
Flags: firefox-backlog+
Assignee | ||
Updated•10 years ago
|
Flags: qe-verify+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florian
Updated•10 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 34.3
Assignee | ||
Comment 1•10 years ago
|
||
This WIP adds all strings, and implements the changes to the doorhanger requesting permissions. Changes to the various sharing indicators we have require a change to nsIMediaManagerService.mediaCaptureWindowState; jesup is on it.
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Updated•10 years ago
|
Attachment #8478282 -
Attachment is obsolete: true
Comment 4•10 years ago
|
||
Updated•10 years ago
|
Attachment #8478287 -
Attachment is obsolete: true
Comment 5•10 years ago
|
||
Updated•10 years ago
|
Attachment #8478288 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8478279 -
Attachment is obsolete: true
Attachment #8479092 -
Flags: review?(gijskruitbosch+bugs)
Comment 7•10 years ago
|
||
Comment on attachment 8479092 [details] [diff] [review] Patch v2 Review of attachment 8479092 [details] [diff] [review]: ----------------------------------------------------------------- Code-wise this seems OK, but see my question below. ::: browser/modules/webrtcUI.jsm @@ +708,3 @@ > webrtcUI.showScreenSharingIndicator = "Window"; > + else if (app.value && !webrtcUI.showScreenSharingIndicator) > + webrtcUI.showScreenSharingIndicator = "Application"; This is odd. Isn't sharing an entire application more important than sharing a window?
Attachment #8479092 -
Flags: feedback+
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #7) > ::: browser/modules/webrtcUI.jsm > @@ +708,3 @@ > > webrtcUI.showScreenSharingIndicator = "Window"; > > + else if (app.value && !webrtcUI.showScreenSharingIndicator) > > + webrtcUI.showScreenSharingIndicator = "Application"; > > This is odd. Isn't sharing an entire application more important than sharing > a window? I did this because showing "Applications" (plural) when I was sharing one application and one window with 2 different tabs felt wrong when I tested it. See bug 1053221 comment 7 for the discussion I had with phlsa on this topic.
Comment hidden (obsolete) |
Updated•10 years ago
|
Attachment #8478308 -
Flags: review?(jib)
Comment 10•10 years ago
|
||
Filed bug 1058944 for comment #9.
Updated•10 years ago
|
Attachment #8479092 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 11•10 years ago
|
||
Comment on attachment 8478308 [details] [diff] [review] split window and app sharing reports so the UI can handle them separately Review of attachment 8478308 [details] [diff] [review]: ----------------------------------------------------------------- r=me with missing %s added. ::: dom/media/MediaManager.cpp @@ +2103,3 @@ > #ifdef DEBUG > nsCOMPtr<nsPIDOMWindow> piWin = do_QueryInterface(aWindow); > LOG(("%s: window %lld capturing %s %s %s %s", __FUNCTION__, piWin ? piWin->WindowID() : -1, need to add another %s
Attachment #8478308 -
Flags: review?(jib) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Fixed minor bitrot in browser.dtd caused by the landing of bug 1043797. Carrying forward Gijs's r+.
Attachment #8479092 -
Attachment is obsolete: true
Attachment #8479817 -
Flags: review+
Assignee | ||
Comment 13•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/af3510fa00fa https://hg.mozilla.org/integration/mozilla-inbound/rev/ffc10f34de13
https://hg.mozilla.org/mozilla-central/rev/af3510fa00fa https://hg.mozilla.org/mozilla-central/rev/ffc10f34de13
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Updated•10 years ago
|
QA Contact: florin.mezei
Comment 15•10 years ago
|
||
I've verified this on the latest Firefox 34 Nightly (BuildID=20140829030204) on Win 7 x64, Mac OS X 10.9.4 and Ubuntu 13.04 x64, and there are no UI issues specific to this implementation (there are some very small issues related to doorhangers in general). The steps used to test this were: - started Firefox Nightly 34 - ensured media.getusermedia.screensharing.enabled = true - set media.getusermedia.screensharing.allowed_domains = queze.net - opened http://queze.net/goinfre/ff_gum_test.html - started Application - verified: display and behaviour of the App Sharing doorhanger and its components (before/after starting to share something), display in the Mac top bar during sharing.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•