1057803 - jit-test/tests/gc/bug-1055034.js will perma-fail when Gecko 34 merges to Aurora

Status: VERIFIED FIXED

(Core :: JavaScript: GC, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Merge day is Tuesday, 2-Sep, so this is semi-urgent. Presumably just needs an early abort if arr.mapPar isn't supported.

https://tbpl.mozilla.org/php/getParsedLog.php?id=46644860&tree=Try

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Looking at the other jit-tests that use mapPar, I guess we'd just want to do this?

-run(range(0, 1024), function (i) { var a = []; a.length = i; });
+if (getBuildConfiguration().parallelJS)
+  run(range(0, 1024), function (i) { var a = []; a.length = i; });

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: only run the test if ParallelJS is supported

Try says this works.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8478224 [details] [diff] [review]
only run the test if ParallelJS is supported

Review of attachment 8478224 [details] [diff] [review]:
-----------------------------------------------------------------

wfm

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ef28e381ad6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3ef28e381ad6

Comment 6

[Bill Gianopoulos [:WG9s]]

OK that makes no sense was test only.

Comment 7

[Bill Gianopoulos [:WG9s]]

but makes me think bug 1055034 is the regressor.