Closed
Bug 105781
Opened 23 years ago
Closed 23 years ago
Check for null channel in nsXPInstallManager::OnProgress
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: dprice, Assigned: dprice)
References
Details
Attachments
(1 file)
|
1.15 KB,
patch
|
mscott
:
superreview+
|
Details | Diff | Splinter Review |
We're getting a null channel in nsXPInstallManager::OnProgress Check for it and return failure instead of crashing.
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Comment 2•23 years ago
|
||
dan, can I get an r=?
|
||
Comment 3•23 years ago
|
||
sure, r=dveditz, but why is the channel null in the first place, something that time and again the networking guys insist is impossible.
|
|
Assignee | |
Comment 4•23 years ago
|
||
I'm marking this as a dependant of 104761. The networking guys are working on
the problem from their end. According to darin's comment in the bug...
>------- Additional Comments From darin@netscape.com 2001-10-22 12:44 -------
>ok, so the file channel is letting file transport requests slip out... bad file
>channel! should be an easy fix.Depends on: 104761
|
|
Assignee | |
Comment 5•23 years ago
|
||
mscott can I get an sr= for this? Thanks
|
||
Comment 6•23 years ago
|
||
Comment on attachment 54326 [details] [diff] [review] a fix sr=mscott In the future, please follow the reviewers guideline and email me directly when you want a review instead of cc'ing me on the bug. Thanks.
Attachment #54326 -
Flags: superreview+
|
|
Assignee | |
Comment 7•23 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Checked in on 11/19/01 as dprice specifies. Low level stuff. Marking Verified.
Status: RESOLVED → VERIFIED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•