1057871 - Make mozconfig errors print the path to the mozconfig in use

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Josh Matthews [:jdm]]

When mach tells me that my mozconfig didn't execute correctly, it would be really useful to print out the full path to the file being executed.

Comment 1

[Josh Matthews [:jdm]]

Relevant code: the MozconfigLoadException in read_mozconfig in http://mxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mozconfig.py

Comment 2

[Arnaud Sourioux [:Six]]

Attachment: mach_print_mozconfig_file.patch

Hello,

Is this the behaviour you want?
It only prints the full path of the mozconfig file used if there is an error in it.

Comment 3

[Josh Matthews [:jdm]]

That looks good to me, but gps should probably review the change. Could you give an example of the output when there's a mozconfig error?

Comment 4

[Arnaud Sourioux [:Six]]

Hi,

ok i will change the reviewer.
Here is the output:

MozconfigLoadException: Using /home/six/mozilla-central/.mozconfig: Evaluation of your mozconfig exited with an error. This could be triggered
by a command inside your mozconfig failing. Please change your mozconfig
to not error and/or to catch errors in executed commands.

Maybe we could change how it's displayed to highlight the file used.

Comment 5

[Josh Matthews [:jdm]]

I would be tempted to use 'Evaluation of %s exited with an error' in this case.

Comment 6

[Arnaud Sourioux [:Six]]

Attachment: mach_print_mozconfig_file.patch

New version taking car of josh comment

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8481321 [details] [diff] [review]
mach_print_mozconfig_file.patch

Review of attachment 8481321 [details] [diff] [review]:
-----------------------------------------------------------------

We already pass the mozconfig path to the created MozconfigLoadException. I'd prefer to fix this bug by ensuring that whatever is printing the MozconfigLoadException is printing the path name, similar to what's happening at https://hg.mozilla.org/mozilla-central/file/5e9826980be5/python/mozbuild/mozbuild/base.py#l590.

What mach command isn't print the mozconfig path?

Comment 8

[Arnaud Sourioux [:Six]]

Hi,

This happens using './mach configure' if there is an error in the mozconfig used.
actually the error is here:
https://hg.mozilla.org/mozilla-central/file/5e9826980be5/python/mozbuild/mozbuild/base.py#l560

it comes from the fact that this "try" block doesn't catch MozconfigLoadException's

Comment 9

[Arnaud Sourioux [:Six]]

Attachment: mach_print_mozconfig_file_v2.patch

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfdcf950e403

Comment 11

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I found that the bug number in the commit message is incorrect. It's 105871 instead of 1057871.

Comment 12

[Carsten Book [:Tomcat]]

(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #11)
> I found that the bug number in the commit message is incorrect. It's 105871
> instead of 1057871.

no problem, backedout the comment with the wrong bugnumber and re-checked in the correct commit message in https://hg.mozilla.org/integration/mozilla-inbound/rev/64300da7c9c4

Comment 13

[Arnaud Sourioux [:Six]]

Thanks TYLin for pointing out my typo and Tomcat for fixing it :)

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64300da7c9c4