1057909 - Job guids with underscores break submission

Status: RESOLVED WORKSFORME

(Tree Management :: Treeherder: API, defect, P4)

Description

[James Lal [:lightsofapollo]]

Example guid _8p2qiUPRg6UMR4VECaTSQ

Comment 1

[James Lal [:lightsofapollo]]

Title correction its any underscore... Trace:

Imperfect trace (but has symbols so should help)

Treeherder traceback
     Traceback (most recent call last):
         File \"/home/vagrant/treeherder-service/vendor/rest_framework/views.py\", line 396, in dispatch
         response = handler(request, *args, **kwargs)
         File \"/home/vagrant/treeherder-service/treeherder/webapp/api/utils.py\", line 238, in use_jobs_model
           return model_func(*args, jm=jm, **kwargs)
         File \"/home/vagrant/treeherder-service/treeherder/webapp/api/utils.py\", line 221, in wrap_oauth
           return func(request, *args, **kwargs)
         File \"/home/vagrant/treeherder-service/treeherder/webapp/api/jobs.py\", line 128, in create
           jm.load_job_data(request.DATA)\n         File \"/home/vagrant/treeherder-service/treeherder/model/derived/jobs.py\", line 1417, in load_job_data
           get_guid_root(row[-1])\n       KeyError: 'H

Looks like it has to due with the get_guid_root checking underscores for some reason.

Comment 2

[Cameron Dawson [:camd]]

We are no longer getting underscores in task ids (guids) from taskcluster, and we now get them via pulse rather than the API, so this is works for me.