1058042 - OpenH264Provider doesn't return the libraries path & filename

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Georg Fritzsche [:gfritzsche]]

The OpenH264Providers getters for pluginLibraries & pluginFullpath return the directory the plugin is in, not the actual library.

Comment 1

[Georg Fritzsche [:gfritzsche]]

The affected parts in the OpenH264Provider:
http://hg.mozilla.org/mozilla-central/annotate/daa84204a11a/toolkit/mozapps/extensions/internal/OpenH264Provider.jsm#l225
http://hg.mozilla.org/mozilla-central/annotate/daa84204a11a/toolkit/mozapps/extensions/internal/OpenH264Provider.jsm#l229
(note that they will change a little from bug 1045209)

We can solve this similar to what this C++ part does (utilizing OPENH264_PLUGIN_ID):
http://hg.mozilla.org/mozilla-central/annotate/daa84204a11a/content/media/gmp/GMPChild.cpp#l79

This test will be affected and will need fixing:
http://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/test_openh264.js

Comment 2

[Benjamin Smedberg]

This is intentional and I don't think it should change. The plugin is both the library and the .info fire.

Comment 3

[Georg Fritzsche [:gfritzsche]]

It's definitely a little awkward now for pluginLibraries, which just returns e.g. |["1.0"]|.

Comment 4

[Anup Kumar [:reznord]]

Hi George,

Currently there are some changes which are made to the code which you gave: 

The old one is: 
http://hg.mozilla.org/mozilla-central/annotate/daa84204a11a/toolkit/mozapps/extensions/internal/OpenH264Provider.jsm#l225 

and the new one is: 
https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/OpenH264Provider.jsm#230

seems like, now I have to take a look at again, I'm a bit confused with the new thing. Can you help me with the changes which are in the new one?

Comment 5

[Benjamin Smedberg]

If you open the DXR page, you will see a "mercurial log" link in the navigation in the upper right corner. Clicking this link will let you see the recent changes to this file including the commit message which will link you to any bugs.

Comment 6

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.