1058296 - Process extensions in packaged tests if they exist

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Thunderbird packaged tests contain the Lightning extension, which buildbot copies over into the bin/extensions directory. We need something similar to make calendar tests run with mozharness.

The patch is untested since I don't have a staging environment, but jcranmer wanted to take care of that.

Comment 1

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8478666 [details] [diff] [review]
Fix - v1

Review of attachment 8478666 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/desktop_unittest.py
@@ +397,5 @@
>                            abs_app_plugins_dir,
>                            overwrite='overwrite_if_exists')
> +            if os.path.isdir(dirs['abs_test_extensions_dir']):
> +                self.copytree(dirs['abs_test_extensions_dir'],
> +                              abs_app_extenions_dir,

Typo: missing s...

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix v2

I took Philipp's patch, ran it through mozharness locally and found a couple of issues.

This patch adds the extensions/ directory to the list of parts of the zip to be unpacked.

It also fixes the directory detection - the extensions directory source is in the "test" directory.

With this, xpcshell tests for a Thunderbird build ran correctly with the lightning extension installed.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8478666 [details] [diff] [review]
Fix - v1

Forgot to obsolete this patch.

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix v2a

Correct patch this time.

Comment 5

[Jordan Lund (:jlund)]

Comment on attachment 8479386 [details] [diff] [review]
The fix v2a

Review of attachment 8479386 [details] [diff] [review]:
-----------------------------------------------------------------

first, sorry for delay; I've been on PTO

hmm, so firefox will not have an extensions dir in the tests zip right?

which means I think we will log the following on every one of our unittest test jobs (aside from thunderbird):
    caution: filename not matched:  extensions

I think that's OK but it is noisy and the configs suggest firefox should have it. could we put a custom 'minimum_tests_zip_dirs' in: http://mxr.mozilla.org/build/source/mozharness/configs/unittests/thunderbird_extra.py instead? Assuming we call that config after say unittests/linux_unittest.py, it will override the anything in linux_unittest.py.

r- to clear my queue. feel free to fight back for an r+ if you do not agree with me :)

Comment 6

[Mark Banner (:standard8)]

Attachment: The fix v3

Yep, using the Thunderbird specific config file seems the better way to go.

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8480435 [details] [diff] [review]
The fix v3

lgtm :)

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8480435 [details] [diff] [review]
The fix v3

https://hg.mozilla.org/build/mozharness/rev/461eb9ef2e34

Comment 9

[Jordan Lund (:jlund)]

patch(es) in production :)

Comment 10

[Joshua Cranmer [:jcranmer]]

Confirmed working.