Closed Bug 1058382 Opened 10 years ago Closed 10 years ago

Reorganize |KeyboardManager. inputFocusChange()|

Categories

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Input Mgmt
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S4 (12sep)

People

(Reporter: mnjul, Assigned: mnjul)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

Patch (PR @ GitHub)
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
Let's reorganize |KeyboardManager.inputFocusChange()| to make it more tangible -- at least the inner activateKeyboard() is unused for some |evt.detail.inputType|s, and we should be able to decouple it.
On my way on this.
Assignee: nobody → jlu
Target Milestone: --- → 2.1 S4 (12sep)
Attached file Patch (PR @ GitHub) — 
Hi Tim,

This is a small patch to extract out the inner function of |KeyboardManager. inputFocusChange()| to tidy up things. Could you help review it? Thanks.
Attachment #8478883 - Flags: review?(timdream)
Comment on attachment 8478883 [details] [review]
Patch (PR @ GitHub)

lgtm, sorry for the delay.
Attachment #8478883 - Flags: review?(timdream) → review+
Final testing after rebasing and before landing at TBPL: https://tbpl.mozilla.org/?rev=7e2bafb6293d3377bc9b2e2c4d6ed0fca9ef068d&tree=Gaia-Try
Whiteboard: [p=1]
Master: https://github.com/mozilla-b2g/gaia/commit/d2a1710b3336050a427aca197b44d5821eb68266
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: