1058573 - Add automated test for showing the toolbars dropdown in customization mode (even if the only toolbar available is the bookmarks toolbar)

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Automated test for bug 1000377:

Add automated test for to check that the toggleable toolbars dropdown is shown in customization mode even if the only toolbar available is the bookmarks toolbar

Comment 1

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: v1

Test for bug1000377.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8480386 [details] [diff] [review]
v1

Review of attachment 8480386 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/test/browser_1058573_showToolbarsDropdown.js
@@ +14,5 @@
> +  yield removeCustomToolbars();
> +
> +  tab = gBrowser.selectedTab;
> +  yield promiseTabLoadEvent(tab, "about:customizing");
> +  info("about:customizing was opened");

You can replace these three lines with:
yield startCustomizing();

@@ +25,5 @@
> +
> +add_task(function asyncCleanup() {
> +  // restore the initial location
> +  gBrowser.addTab(initialLocation);
> +  gBrowser.removeTab(tab);

These can be replaced with:
yield endCusotmizing();

which will make the `let tab = null; let initialLocation = gBrowser.currentURI.spec;` at the top of this file unneeded.

Comment 3

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: v2

Updated based on review

Comment 4

[Mihaela Velimiroviciu (:mihaelav)]

Thanks Jared.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/7c28c12de7aa

Comment 6

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/7c28c12de7aa