1058587 - OdinMonkey MIPS: Bias the global-register to improve instruction encoding efficiency

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Branislav Rankov [:rankov]]

This is followup on ARM bug 1051595.

Comment 1

[Douglas Crosher [:dougc]]

Attachment: Bias the global-register to improve instruction encoding efficiency.

Here's the suggested patch. This was tested, but with other pending patches applied, so could use retesting.

Comment 2

[Douglas Crosher [:dougc]]

Attachment: Bias the global-register to improve instruction encoding efficiency.

With the uses in GenerateAsyncInterruptExit() also patched, thanks.

Comment 3

[Branislav Rankov [:rankov]]

Comment on attachment 8479042 [details] [diff] [review]
Bias the global-register to improve instruction encoding efficiency.

Review of attachment 8479042 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Might need a rebase because I landed the patches from bug 972836

::: js/src/asmjs/AsmJSValidate.cpp
@@ -6647,3 @@
>      masm.pop(HeapReg);
>      masm.as_jr(HeapReg);
> -    masm.loadPtr(Address(GlobalReg, AsmJSModule::heapGlobalDataOffset()), HeapReg);

nit: Line over 99 characters

::: js/src/jit/mips/CodeGenerator-mips.cpp
@@ +2184,5 @@
>      Register tmp = ToRegister(ins->temp());
>      Register out = ToRegister(ins->output());
>      unsigned addr = mir->globalDataOffset();
>  
> +    BaseIndex source(GlobalReg, index, TimesFour, addr - AsmJSGlobalRegBias);

Maybe change addr above for consistency.

Comment 4

[Douglas Crosher [:dougc]]

Attachment: Bias the global-register to improve instruction encoding efficiency.

Rebase. Carry forward r+.

Comment 5

[Douglas Crosher [:dougc]]

This only touches the MIPS backend which is not tested by tbpl, so requesting checkin without a try build

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55ada902c145

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/55ada902c145