Closed
Bug 1058879
Opened 10 years ago
Closed 10 years ago
Enable canvasdebugger tests for e10s
Categories
(DevTools Graveyard :: Canvas Debugger, defect)
DevTools Graveyard
Canvas Debugger
Tracking
(e10s+)
RESOLVED
FIXED
Firefox 36
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: bgrins, Assigned: jsantell)
References
Details
Attachments
(3 files, 1 obsolete file)
726 bytes,
patch
|
vporof
:
review+
bgrins
:
checkin+
|
Details | Diff | Splinter Review |
37.28 KB,
patch
|
pbro
:
review+
bgrins
:
checkin+
|
Details | Diff | Splinter Review |
11.61 KB,
patch
|
jsantell
:
review+
cbook
:
checkin+
|
Details | Diff | Splinter Review |
These are currently failing on Holley: https://tbpl.mozilla.org/?tree=Holly. Here is an example: https://tbpl.mozilla.org/php/getParsedLog.php?id=46482670. Seems the call to target.window.wrappedJSObject is failing: http://dxr.mozilla.org/mozilla-central/source/browser/devtools/canvasdebugger/test/head.js#188.
Reporter | ||
Comment 1•10 years ago
|
||
First step: skip the failing tests so we can get the tree green
Attachment #8479318 -
Flags: review?(vporof)
Reporter | ||
Updated•10 years ago
|
Keywords: leave-open
Updated•10 years ago
|
Attachment #8479318 -
Flags: review?(vporof) → review+
Reporter | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=4d3de8a8f07d
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/21496f6351e4
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/21496f6351e4
Whiteboard: [fixed-in-fx-team]
Updated•10 years ago
|
tracking-e10s:
--- → +
Reporter | ||
Updated•10 years ago
|
Attachment #8479318 -
Flags: checkin+
Comment 5•10 years ago
|
||
This patch is very similar to the one in bug 1072141 etc. A key difference here is that there is a single test that relies on the "debuggee" - so this patch just disables that single test in e10s (and thus, I'll keep the "leave-open" annotation to track that one final test)
Attachment #8494902 -
Flags: review?(pbrosset)
Comment 6•10 years ago
|
||
Comment on attachment 8494902 [details] [diff] [review] 0002-Bug-1058879-enable-most-canvasdebugger-tests-in-e10s.patch Review of attachment 8494902 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8494902 -
Flags: review?(pbrosset) → review+
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f26dcd7a38ac
Flags: in-testsuite+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jsantell
Assignee | ||
Comment 9•10 years ago
|
||
This enables browser_canvas-actor-test-10.js
Attachment #8505109 -
Flags: review?(vporof)
Assignee | ||
Comment 10•10 years ago
|
||
try build for none10s, passes locally with e10s https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=573756bd0fe7
Comment 11•10 years ago
|
||
Comment on attachment 8505109 [details] [diff] [review] 1058879-enable-canvas-test-e10s.patch Review of attachment 8505109 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8505109 -
Flags: review?(vporof) → review+
Reporter | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Updated•10 years ago
|
Attachment #8494902 -
Flags: checkin+
Assignee | ||
Updated•10 years ago
|
Attachment #8505109 -
Flags: checkin?
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 12•10 years ago
|
||
I believe this is the last patch needed for this tool to be enabled in e10s.
Comment 13•10 years ago
|
||
Hi Jordan, the patch didn't apply cleanly: patching file browser/devtools/shared/frame-script-utils.js Hunk #1 FAILED at 11 1 out of 1 hunks FAILED -- saving rejects to file browser/devtools/shared/frame-script-utils.js.rej patch failed, unable to continue (try -v) patch failed, rejects left in working dir errors during apply, please fix and refresh 1058879-enable-canvas-test-e10s.patch could you take a look, thanks!
Flags: needinfo?(jsantell)
Updated•10 years ago
|
Keywords: checkin-needed
Comment 14•10 years ago
|
||
Comment on attachment 8505109 [details] [diff] [review] 1058879-enable-canvas-test-e10s.patch Presumably you want to remove leave-open too?
Attachment #8505109 -
Flags: checkin?
Assignee | ||
Comment 15•10 years ago
|
||
Rebased and good to go!
Attachment #8505109 -
Attachment is obsolete: true
Flags: needinfo?(jsantell)
Attachment #8513753 -
Flags: review+
Attachment #8513753 -
Flags: checkin?(cbook)
Comment 17•10 years ago
|
||
Comment on attachment 8513753 [details] [diff] [review] 1058879-enable-canvas-test-e10s.patch remote: https://hg.mozilla.org/integration/fx-team/rev/aa97afb0a949
Attachment #8513753 -
Flags: checkin?(cbook) → checkin+
Comment 18•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aa97afb0a949
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•