1058888 - enable android 2.3 release/test builders on esr31 branch

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Kim Moir [:kmoir] ET]

buildbot configs to support the work in bug 1040319

Comment 1

[Kim Moir [:kmoir] ET]

We can use the the build slave in bug 1059047 and the test slave in bug 1058734 for the dev-master testing.

Comment 2

[Kim Moir [:kmoir] ET]

I've installed a new dev-master here that I can use for testing. /builds/buildbot/kmoir/build3/  We can integrate my patches into Pete's dev-master once his other patches are landed.

Comment 3

[Kim Moir [:kmoir] ET]

I put my patches for this in bug 1040319 last week so I think we can close this.

Comment 4

[Kim Moir [:kmoir] ET]

There are nightly builder for this branch, however the test jobs on emulators are needed (as confirmed in today's mobile meeting)

Comment 5

[Kim Moir [:kmoir] ET]

Attachment: bug1058888.patch

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: bug1058888builder.diff

builder diff

Comment 7

[Kim Moir [:kmoir] ET]

diff from enabling the android esr31 test jobs on emulators, not tegras.  As a note, right now we just have esr31 nighties, my thinking is that the unittest sendchange from the nightly will start the test jobs.  Talos jobs will not be run.

Comment 8

[Pete Moore [:pmoore][:pete]]

Sorry Kim I've been on PTO for a few days. I was back this afternoon but did not get around to looking deeply into this (although superficially it looks very good) - I will review first thing in the morning. Thanks for taking care of this!
Pete

Comment 9

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8488160 [details] [diff] [review]
bug1058888.patch

Review of attachment 8488160 [details] [diff] [review]:
-----------------------------------------------------------------

Looks pretty good to me Kim! Thanks for this. The diffs look good, and the code changes too, and I ran mobile_config.py before and after, and the diff there looks sane too.

::: mozilla-tests/mobile_config.py
@@ +1472,4 @@
>          'tegra_android-armv6': {
>              'opt_unittest_suites': [],
>              'debug_unittest_suites': [],
> +        },       

some trailing whitespace

Comment 10

[Kim Moir [:kmoir] ET]

Comment on attachment 8488160 [details] [diff] [review]
bug1058888.patch

and fixed whitespace

Comment 11

[Justin Wood (:Callek)]

In production

Comment 12

[Kim Moir [:kmoir] ET]

Verified that tests ran