1059625 - Detach MediaSource upon decoder shutdown

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

If the decoder shuts down (due to an error, for example), detach the MediaSource to stop the MediaSource trying to use the MediaSourceDecoder's resources.

Inspired by bug 1059569.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Detach MediaSource upon decoder shutdown.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Detach MediaSource upon decoder shutdown

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8480960 [details] [diff] [review]
Detach MediaSource upon decoder shutdown

This broke a crashtest; need to handle detaching twice.

Comment 4

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a69a71936ce

Comment 5

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/169a90f344da

Comment 6

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #5)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/169a90f344da

That was for:

https://tbpl.mozilla.org/php/getParsedLog.php?id=46989177&full=1&branch=mozilla-inbound#error1

Which is a null deref because the CC already cleared the pointers.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a69a71936ce
https://hg.mozilla.org/mozilla-central/rev/169a90f344da