1059662 - embed-apps should be restricted to in-proc apps or we need to fix oop-embed-apps

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

In bug 1044333 we realized that apps managed by an OOP app would use the incorrect AppId, the parent app's AppId, so it would cause privilege escalation.

In the short term we should disallow apps with embed-apps permission to be run OOP.

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Disallow OOP app to embed in-proc apps

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b445bb36bc51

This might break some emulator tests..

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8513262 [details] [diff] [review]
Disallow OOP app to embed in-proc apps

Review of attachment 8513262 [details] [diff] [review]:
-----------------------------------------------------------------

Please ask review once treeherder is happy!

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Disallow OOP app to embed in-proc apps

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a74ef8f2086e

Tree is greenish.. failing tests are disabled since they use embed-apps in oop env.

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/b2g-inbound/rev/138110eb6437

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/138110eb6437

Comment 6

[Ryder15]

Yeah you are right, Few app like Grammarly which we need for running https://apkblink.com/ is not working in the browsers. Although the app works in other browsers. As contact to their support team they answered me to reinstall you browser. I did the same but nothing happened facing same issue.