1059847 - logviewer: Clicking an error line for a log deleted from ftp shows perpetual "Loading..."

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

1) Find a Try job that ran >30 days ago (since that's the timeframe for logs being purged from ftp for try jobs). eg https://treeherder.mozilla.org/ui/logviewer.html#?job_id=1013218&repo=try
2) Click on one of the errors in the overview

Expected:
Error message of "Log not found"

Actual:
Perpetual "Loading..."

Webconsole shows:
GET https://treeherder.mozilla.org/api/project/try/logslice/ [HTTP/1.1 404 NOT FOUND 216ms]

And https://treeherder.mozilla.org/api/project/try/logslice/?end_line=7050&job_id=1013218&start_line=6800 returns:
{"detail": "log file not found"}

Comment 1

[David Burns :automatedtester]

Attachment: Show log not available error

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/3dab70bf5b80cce36791111eb116ce0fa65fd3c1
Bug 1059847: Show 'Log not found error' instead of 'loading' when the log is no longer available

https://github.com/mozilla/treeherder-ui/commit/acaa14ebca07b2123069043cc69c1b280b8e2e9a
Merge pull request #173 from AutomatedTester/1059847

Bug 1059847: Show 'Log not found error' instead of 'loading' when the log is no longer available

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/68feb17759eb6b8d8b6b2b71ced9def549b8faf3
Bug 1059847: Show 'Log not found error' instead of 'loading' when the log is no longer available

https://github.com/mozilla/treeherder/commit/0b222480ac757b2fa90afebcdfa7b6d662fd5a4a
Merge pull request #173 from AutomatedTester/1059847

Bug 1059847: Show 'Log not found error' instead of 'loading' when the log is no longer available