1060159 - [RPP] Detect if the screen lock is on

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[marta]

In case user wants to be able to remotely lock his phone we need to detect if the screen lock was activated.

Comment 1

[marta]

And if it was not - we need to take him to settings and get him to activate the screen lock

Comment 2

[agnieszka.baranowska]

To detect if user has active 'lock screen' and 'passcode lock' it's quite simple - we need to check parameters 'lockscreen.enabled' and 'lockscreen.passcode-lock.enabled'.
In situation when user won't have active lock screen or passcode lock, do you agree Marta that we display custom panel with two inputs to enter passcode (second input for confirmation) instead of taking user to Settings app beacuse AFAIK we can launch Settings app (via Web Activities API) but only main window - it doesn't allow to redirect to 'Screen lock' window?

Comment 3

[agnieszka.baranowska]

Existing application 'Find my Device' has a opportunity to send lock command with passcode. This passcode will be used if user hasn't had active screen lock or passcode lock. Maybe we should extend lock command and add passcode parameter.

Comment 4

[marta]

As explained in the email - this functionality should not be allowed in the current state. Once we implement the hidden SMS then the option of setting the lock with a passphrase in the SMS will be feasible, as long as we allow only one time SMS (so once the message is sent phone locks itself and stops reacting to new messages)

Comment 5

[Dave Huseby [:huseby]]

As Marta stated, as long as we're not using hidden SMS messages, we should not allow remote locking if the user has not set a passphrase.  Normally I would say that we should look into hidden SMS support but considering the tight deadline and current circumstances, I think we need to push this feature off until v2.2.

Comment 6

[agnieszka.baranowska]

I have another idea. Lock command leaves as it is now (FmD: LockDevice testPassKey123). SMS listener receives lock command and invokes lock command from Find My Device app with random generated passcode. If user doesn't have active passcode lock, the generated passcode is used. In reply user (phone from which lock command was sent) received SMS with text:
1) case: user has active passcode lock
FmD: <deviceId> locked remotly at time: <time>
2) case: user has active passcode lock
FmD: <deviceId> locked remotly with code: <passcode> at time: <time>

Comment 7

[marta]

Yes, agreed. Great solution.

Comment 8

[agnieszka.baranowska]

Marta, do you agree that if we implement solution with random generated passcode, we don't need to check if screen lock is on (we don't have to worry about it). We make change in implemention of lock command, which deals with a case when user don't have active lock screen or passcode lock.
Can we close the bug with this comment?

Comment 9

[marta]

Is this lock code our custom one or done with the use of FmD lock?

Comment 10

[agnieszka.baranowska]

I invoke FmD lock command which has three parameters - one of them is passcode.

Comment 11

[marta]

We cannot change the fmD lock command. We can only invoke it. So the only thing that you can do is create a passcode if it is not available and pass the argument to fmd lock, so that as far as fmd lock is concerned the passcode is always there

Comment 12

[agnieszka.baranowska]

Ok, when I wrote "We make change in implemention of lock command" I meant that we will change invocation of FmD lock command - so far we invoked with null as passcode, now we put there random generated passcode.

Comment 13

[marta]

agreed.

Comment 14

[marta]

The required code is now included in the patch for bug 1060164