1060384 - Dialer and Contacts apps have name of "Communications"

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Zac C (:zac)]

Attachment: 2014-08-29-15-32-06.png

Since this first failing b2g-i build, 

https://tbpl.mozilla.org/?tree=B2g-Inbound&showall=1&rev=8a797fb5d9ad

Dialer and Contacts apps have the name of "Communication" when viewed from the task manager.

Previously they were "Phone" and "Contacts".

There is some debate over whether this should have been changed or not.

Comment 1

[Zac C (:zac)]

Forgot to mention that this is causing some on-device automation to fail because they are expecting the same name of the entry point we've taken into the app.

I won't adjust the automated test until a decision is made.

Comment 2

[Anthony Ricaud (:rik)]

We shouldn't change the name of those apps.

Comment 3

[Staś Małolepszy :stas]

It looks like a regression from bug 1012702. I'll fix it.

Comment 4

[Staś Małolepszy :stas]

A little bit of investigation revealed that this was broken even before bug 1012702 landed, but only for pseudolocales.

Comment 5

[Staś Małolepszy :stas]

I think I found the root cause.  It's a typo here (locale instead of locales):

https://github.com/mozilla-b2g/gaia/blob/dd264985a94f63a10a6270a4088cd6ea8e513aac/apps/system/js/browser_config_helper.js#L73

which accidentally makes the names of virtual apps to work for all locales except for pseudolocales.  If I fix the typo, the bug can be reproduced for all locales.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

So, I'm wondering how zac got this bug in en-US.

Comment 7

[Staś Małolepszy :stas]

It was probably due to the buildtime regression from the original landing of bug 1022767 which caused the backout.  I was able to reproduce this for en-US on b7950aa (which was reverted) with the following command:

  MOZILLA_OFFICIAL=1 LOCALES_FILE=locales/languages_dev.json LOCALE_BASEDIR=locales/ make production

It did not reproduce for en-US without LOCALE_BASEDIR and does not reproduce for en-US on the current master.

Comment 8

[Staś Małolepszy :stas]

This isn't an L10n bug.  This should have never worked but it didn't thanks to a typo:

https://github.com/mozilla-b2g/gaia/blob/c7b8e74c972990750fb40c33b646b50a08c9fd40/apps/system/js/browser_config_helper.js#L73

  key !== 'locale'

should read:

  key !== 'locales'

If you fix the typo, this bug can be reproduced for all locales.

The true reason of the bug is that in the following places:

https://github.com/mozilla-b2g/gaia/blob/c7b8e74c972990750fb40c33b646b50a08c9fd40/apps/system/js/app_window.js#L127
https://github.com/mozilla-b2g/gaia/blob/c7b8e74c972990750fb40c33b646b50a08c9fd40/apps/system/js/app_window.js#L764

…AppWindow uses ManifestHelper directly, without applying the logic similar to the one in BrowserConfigHelper which selects the current entry point.

Moving to the appropriate component.

Comment 9

[Jason Smith [:jsmith]]

QA Wanted for branch checks (pretty sure this is a regression).

Comment 10

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Jason Smith [:jsmith] from comment #9)
> QA Wanted for branch checks (pretty sure this is a regression).

I'm unable to reproduce this issue on latest master or on 8/29 master when this bug was reported. Phone app and Contacts app are correctly labeled in task manager.

What is the STR for manual reproduction? It looks like something special needs to be done but I'm not sure how.

Tested on:
Device: Flame
BuildID: 20140910060915
Gaia: f108c706fae43cd61628babdd9463e7695b2496e
Gecko: 843332cc69af
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame
BuildID: 20140829055602
Gaia: 007f3c50cf69f044628a23c2376c6d88aa45f617
Gecko: 5f66dd3d63f2
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

The bug is only present in Pseudolocales unless you fix a typo as described in comment 8.

Comment 12

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Zibi Braniecki [:gandalf] from comment #11)
> The bug is only present in Pseudolocales unless you fix a typo as described
> in comment 8.

What I did:
1) Go to Settings > Developer > check 'Pseudo-localization' box
2) Change language to Japanese
3) Launch Phone and Contacts apps
4) Long press Home button and observe their names in Task Manager

What I'm seeing is correct task manager names. Please add any steps necessary in order to reproduce the bug.

Tested on:
Device: Flame
BuildID: 20140910060915
Gaia: f108c706fae43cd61628babdd9463e7695b2496e
Gecko: 843332cc69af
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to Pi Wei Cheng [:piwei] from comment #12)
> (In reply to Zibi Braniecki [:gandalf] from comment #11)
> > The bug is only present in Pseudolocales unless you fix a typo as described
> > in comment 8.
> 
> What I did:
> 1) Go to Settings > Developer > check 'Pseudo-localization' box
> 2) Change language to Japanese

Change language to Accented English instead

Comment 14

[Pi Wei Cheng [:piwei] (inactive)]

Finally able to repro with the info added on comment 13.

Branch check results:

This issue is present in Flame 2.2, Flame 2.1, and Open C 2.2.

Device: Flame 2.2 Master
BuildID: 20140910060915
Gaia: f108c706fae43cd61628babdd9463e7695b2496e
Gecko: 843332cc69af
Version: 35.0a1 (2.2 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20140910122556
Gaia: 6cb9de2c10070dc638ed9bc083ad5ff9a065db36
Gecko: fcbfbd3cba3f
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Device: Open_C 2.2 Master
BuildID: 20140910060915
Gaia: f108c706fae43cd61628babdd9463e7695b2496e
Gecko: 843332cc69af
Version: 35.0a1 (2.2 Master)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

---------

Pseudo-localization option is NOT available in Flame 2.0 therefore unable to check for regression. Comment 8 also indicates that this is a feature that was implemented broken.

Comment 15

[Joshua Mitchell (Inactive)]

Not nomming, not a regression, text bug, not proper name but something close at least.

Comment 16

[BMO Automation]

Firefox OS is not being worked on