Closed
Bug 1060431
Opened 10 years ago
Closed 10 years ago
Somewhat misleading and confusing message from async animation in nsDisplayList.cpp
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: milan, Assigned: milan)
Details
Attachments
(1 file, 1 obsolete file)
2.60 KB,
patch
|
milan
:
review+
|
Details | Diff | Splinter Review |
When the animations are logged, the user may get a "Async animation disabled because frame size ... is bigger than the viewport ..." even when the frame size is smaller than the viewport - because the size of the visual rectangle goes beyond the current maximum (4096 dev pixels.)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → milan
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8481372 -
Flags: review?(tnikkel)
Assignee | ||
Comment 2•10 years ago
|
||
No rush whatsoever on this review, it's obviously just a minor thing.
Comment 3•10 years ago
|
||
Comment on attachment 8481372 [details] [diff] [review] More descriptive message when async animation is not being done. Can we use just one variable to hold 4096 dev pixels in app units? So they don't get out of sync if we ever change it.
Attachment #8481372 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Timothy Nikkel (:tn) from comment #3) > Comment on attachment 8481372 [details] [diff] [review] > More descriptive message when async animation is not being done. > > Can we use just one variable to hold 4096 dev pixels in app units? So they > don't get out of sync if we ever change it. Good idea, will do. https://tbpl.mozilla.org/?tree=Try&rev=f57a9516099d
Assignee | ||
Comment 5•10 years ago
|
||
With review comments addressed.
Attachment #8489450 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Attachment #8481372 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c061af84898d
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c061af84898d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•