1061007 - Handle SourceBuffer appends that are not aligned on a random access point

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

ContainerParser currently assumes that each append starts on a random access point (e.g. init segment or cluster) and contains a complete chunk.  That's not something that the spec requires so ContainerParser must be extended to handle non-aligned appends.

This is important right now because YouTube use this to append ~64kB chunks as a way of controlling the streaming rate of XmlHttpRequests.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: wip

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Handle unaligned appends by retaining WebM parser state across calls. r=cajbir

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: Handle unaligned appends by retaining WebM parser state across calls. r=cajbir

Same as before, but with cruft excluded.

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8482186 [details] [diff] [review]
Handle unaligned appends by retaining WebM parser state across calls.  r=cajbir

Still has cruft.

Comment 5

[Matthew Gregan [:kinetik]]

Attachment: Handle unaligned appends by retaining WebM parser state across calls. r=cajbir

Comment 6

[Matthew Gregan [:kinetik]]

Attachment: Only start new decoder on media segment boundary.

Comment 7

[cajbir (:cajbir)]

(In reply to Matthew Gregan [:kinetik] from comment #6)
> Created attachment 8482449 [details] [diff] [review]
> Only start new decoder on media segment boundary.

What does this patch apply on top of? I get conflicts with SourceBuffer.cpp in ParseStartAndEndTimestamps.

Comment 8

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/478f4c80061a
https://hg.mozilla.org/integration/mozilla-inbound/rev/57db771b7b9d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/478f4c80061a
https://hg.mozilla.org/mozilla-central/rev/57db771b7b9d