1061226 - markdown isn't linkifying urls

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[:glob ✱]

markdown isn't linkifying all urls.

eg.

http://www.example.com
[e-mail]

currently http://www.example.com isn't converted to a link when markdown is enabled, however it is when markdown is disabled.

Comment 1

[Koosha KM]

That's because according to Markdown specification and its original implementation, you need to surround URLs with angle brackets. [1] But, that should be linkified anyway. Also, if we follow Markdown standards, we need to decide whether to omit angle brackets after linkifiying or leave them unchanged. Bugzilla does not remove them but standard Markdown does.

[1]: http://daringfireball.net/projects/markdown/syntax#autolink

Comment 2

[Koosha KM]

Attachment: patch-v1.0

This might be a nasty hack!

Comment 3

[:glob ✱]

Comment on attachment 8488277 [details] [diff] [review]
patch-v1.0

Review of attachment 8488277 [details] [diff] [review]:
-----------------------------------------------------------------

this needs to operate the same as quoteUrls (ie. honour SAFE_PROTOCOLS).

Comment 4

[Koosha KM]

Attachment: patch-v2

Comment 5

[Koosha KM]

Attachment: patch-v2

Comment 6

[:glob ✱]

Comment on attachment 8490826 [details] [diff] [review]
patch-v2

Review of attachment 8490826 [details] [diff] [review]:
-----------------------------------------------------------------

this is much better, however it doesn't cope well with links within quotes.

> "http://example.com"
comes out as
> "http://example.com&quot

the comment for _DoAutoLinks will also need updating.

Comment 7

[David Lawrence [:dkl]]

Hi Koosha. Just looking at some of the remaining unresolved issues that is blocking us from branching for 5.0. This bug is one and was wondering if you will be able to take a look at this soon. I don't mind taking it if you are not going to be able able to. 

Thanks
dkl

Comment 8

[Koosha KM]

(In reply to David Lawrence [:dkl] from comment #7)
> Hi Koosha. Just looking at some of the remaining unresolved issues that is
> blocking us from branching for 5.0. This bug is one and was wondering if you
> will be able to take a look at this soon. I don't mind taking it if you are
> not going to be able able to. 
> 
> Thanks
> dkl

OK, you can take it. But, take care not to double-linkify link definitions in reference-style links while you patch this bug.

Comment 9

[Albert Ting]

Attachment: alternative v1

Attached is an alternative solution where I handle it in DoAnchors.

The only situation this patch is not able to handle is something like below, where a ';' appears just before the url.  This is because I need to do a negative lookbehind to ignore both &lt; and ['"<>].  Perhaps somebody can take this further.  

  ;http://mozilla.org

Comment 10

[David Lawrence [:dkl]]

Comment on attachment 8579747 [details] [diff] [review]
alternative v1

Review of attachment 8579747 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: Bugzilla/Markdown.pm~
@@ +258,5 @@
>  
> +    # Last, handle "naked" references
> +    # Caveat, does not handle ;http://amazon.com
> +    $text =~ s{
> +        (                    

remove whitespace

Comment 11

[David Lawrence [:dkl]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   1fbcede..1fa1aa5  master -> master