1061267 - Error message for unverified account shows up when offline

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Guilherme Gonçalves [:ggp]]

STR:
1- Make sure the device is offline
2- Open the Settings app and navigate to Find My Device
3- Observe the message that reads "Click the verification link in your email to confirm your account"

Expected: the message shouldn't appear.

Note: this bug manifests itself regardless of whether you're logged out, or logged in with a verified account.

Comment 1

[Guilherme Gonçalves [:ggp]]

Attachment: GitHub pull request

Comment 2

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8482369 [details] [diff] [review]
GitHub pull request

This PR hides the error message by default, and adds a couple of tests. Also, I've moved the code that was previously in suiteSetup/suiteTeardown to setup/teardown, as that was causing dependencies between tests.

Comment 3

[vkrishnamoorthy]

[Blocking Requested - why for this release]:this is a bad user experience.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8482369 [details] [diff] [review]
GitHub pull request

Looks good to me, thanks!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Have you confirmed that the Linter failures in the Gaia-Try run aren't yours? They don't look related, but I also don't see anything like those on b2g-inbound from a busted landing.

Comment 6

[Guilherme Gonçalves [:ggp]]

I rebased an re-ran this through Gaia-Try, the linter tests are green again.
https://tbpl.mozilla.org/?rev=219021952f128b3a2fac2c2c65fdd4533262cb9a&tree=Gaia-Try

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Thanks :)

Master: https://github.com/mozilla-b2g/gaia/commit/19c62641af84b275ed92a2ab867df7ea988c4186

Comment 8

[bhavana bajaj [:bajaj]]

Is this a regression in 2.1?, which is the only reason I would consider blocking for 2.1+

You are free to seek approval for 2.1 on this to consider it for landing either ways(blocking or non-blocking).  Depending on the risk/reward, we can consider uplift here. So could you please do that ?

Comment 9

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8482369 [details] [diff] [review]
GitHub pull request

This is a bug that went unnoticed from 2.0, so it's not a regression. I'll request approval then, as this is a very low-risk fix for an unlikely bug.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1037232
[User impact] if declined: An error string will erroneously appear when offline
[Testing completed]: Manual and Gaia unit testing
[Risk to taking this patch] (and alternatives if risky): Very low
[String changes made]: None

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/c7b55ed3be126b1f5f3d9cdd0277c365a6652d29

Comment 11

[Dietrich Ayala (:dietrich)]

Triage reviewed, blocking- per comment #8 and #9.

Comment 12

[Coler]

This issue has been verified successfully on Flame2.1&2.2, it will prompt "This device is currently offline.Connect to a network and try again" when tapping the "Create account or sign in".
Reproducing rate: 0/5
See attachment: Verify_Flame_FMD.mp4

Flame2.1 build version:
Gaia-Rev        5655269098c7e82254e56933f1af05b4abe2a2f3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86608c9389b5
Build-ID        20141204001201
Version         34.0

Flame2.2 build version:
Gaia-Rev        984e6d79aa799d2695f9ca132dfdc1665a56c019
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/a9fc46355661
Build-ID        20141204040202
Version         37.0a1

Comment 13

[Coler]

Attachment: Verify_Flame_FMD.MP4