106127 - Polish search results in sidebar

Status: VERIFIED FIXED

(SeaMonkey :: Search, enhancement, P2)

Description

[Samir Gehani]

1. Splitting list to show limited number and inserting "prev" and "next" .
2. Making items more distinct from each other: adding more vertical space
between results?

Matt, Marlon,
Feel free to add other items that need to be done for this feature.

Comment 1

[Samir Gehani]

Taking for mozilla0.9.7.

Comment 2

[Todd Pringle]

Another thing we need to do here is to crop the link underline (that appears
when mousing over results) so that it is only as long as the text, not as wide
as the sidebar regardless as it is now.  I think this bug also affects the WR
panel, but that is of a lower priority to fix.

Comment 3

[Alex Bishop]

Would it also be possible to make the mouseover cursor a hand rather than an
arrow? I mean, they're links after all.

Comment 4

[Samir Gehani]

Alex,
Yes, that is possible and I'll do it too when I get to this bug.

Comment 5

[Samir Gehani]

-> mozilla0.9.8

Comment 6

[Samir Gehani]

Here is a more comprehensive list of polish items in the search tab:
    * search results navigation
    * results should behave like links:
          * blue underline
          * red on active
          * purple on visited
          * mouseover cursor should be hand
          * underline only title length
    * icon atop results and search engine name (when in basic mode)
    * description in tooltips
    * remove "bookmark this search"
    * wrapped result titles
    * bulleted results vs. icons (when in basic mode)

Comment 7

[Jaime Rodriguez, Jr.]

what are the chances this will make 098?

Comment 8

[Samir Gehani]

Search triage team: nsbeta1+

Comment 9

[Samir Gehani]

We are not doing the following:
 * icon atop results and search engine name (when in basic mode)
   Why not?  Because the engine name is in the menulist and it appears redundant.

 * description in tooltips
   Why not?  Not part of Sherlock spec.  We aren't extending Sherlock this time.

 * wrapped result titles
   Why not?  Looks ugly, needs time we don't have right now, and tooltips
   suffice.

 * bulleted results vs. icons (when in basic mode)
   Why not?  Because the engine icons are needed for mixed results in 
   Advanced mode.  And because doing special stuff to swap the icon after 
   the results have loaded for either mode means a performance hit.

Comment 10

[Samir Gehani]

Note, we have included drag support so links can now be dragged from the search
results tab to the content area to load a URL or to the URL or for pasting into
the editor or a textfield.

Comment 11

[Samir Gehani]

Attachment: Patch for listed items here.

This patch also covers:
bug 93624:  visited links in the search tab do not change color
bug 118030: Move search item to bottom of context menu per spec
bug 114972: Search context menu item should be visible but disabled even when 
	    text not selected

All 3 bugs are nsbeta1+.

Comment 12

[Samir Gehani]

morse, please r.
hewitt, please sr.

Thanks.

Comment 13

[Stephen P. Morse]

Comment on attachment 71816 [details] [diff] [review]
Patch for listed items here.  

r=morse

Comment 14

[Joe Hewitt (gone)]

Comment on attachment 71816 [details] [diff] [review]
Patch for listed items here.  

sr=hewitt

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 71816 [details] [diff] [review]
Patch for listed items here.  

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 16

[Samir Gehani]

Fix checked in.

Comment 17

[Claudius Gayle]

VERIFIED Fixed with 20020322 builds