Closed
Bug 1061337
Opened 10 years ago
Closed 10 years ago
Error when bookmarking a URL from Twitter
Categories
(Firefox for Android Graveyard :: Overlays, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
1.39 KB,
patch
|
ckitching
:
review+
|
Details | Diff | Splinter Review |
Doesn't have a title, so: java.lang.IllegalArgumentException: the bind value at index 1 is null at android.database.sqlite.SQLiteProgram.bindString(SQLiteProgram.java:164) at android.database.sqlite.SQLiteProgram.bindAllArgsAsStrings(SQLiteProgram.java:200) at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:68) at android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:1370) at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:421) at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:354) at org.mozilla.gecko.db.BrowserProvider.query(BrowserProvider.java:851) at android.content.ContentProvider.query(ContentProvider.java:869) at android.content.ContentProvider$Transport.query(ContentProvider.java:212) at android.content.ContentResolver.query(ContentResolver.java:476) at android.content.ContentResolver.query(ContentResolver.java:419) at org.mozilla.gecko.db.LocalBrowserDB.addBookmark(LocalBrowserDB.java:1005) at org.mozilla.gecko.overlays.service.sharemethods.AddBookmark.handle(AddBookmark.java:22) at org.mozilla.gecko.overlays.service.OverlayActionService$1.run(OverlayActionService.java:118) at android.os.Handler.handleCallback(Handler.java:733) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:157) at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:32)
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8482438 -
Flags: review?(chriskitching)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8482438 [details] [diff] [review] Don't try to bind a null title. v1 Review of attachment 8482438 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, but ill look strange in ui. just the small text for he url and nothing else.
Attachment #8482438 -
Flags: review?(chriskitching) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Yup, nothing we can do about that yet. All this does is stop us crashing on insert!
Comment 4•10 years ago
|
||
String process he url to try and et something usable s a provisional title? Change the way we sh ow bookmarks in this case? Eventually i guess we wan theaddless gecko to fetch it for us. Also, my phone keYboard freezes for ten seconds at random intervals while i type o bugzilla.... Firefox bug methinks?
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/851cc4154553
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Chris Kitching [:ckitching] from comment #4) > String process he url to try and et something usable s a provisional title? > Change the way we sh ow bookmarks in this case? We should be able to show a title-less bookmark reasonably well. > Eventually i guess we wan theaddless gecko to fetch it for us. Yes. > Also, my phone keYboard freezes for ten seconds at random intervals while i > type o bugzilla.... Firefox bug methinks? File it... when you're back at a keyboard!
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/851cc4154553
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•