1061532 - OMA CP received settings are not included in APN list properly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Beatriz Rodríguez [:brg]]

Attachment: 2014-08-29-13-26-28.png

Flame, master(2.1), Gecko-2fbbb04.Gaia-59bd661, the setting received is not properly included in the APN list. see screenshot.

The new profile received via OMA CP is called Telefonica and the APN name is telefonica.es. The list must include "Telefonica" instead of "telefonica.es"

The expected behaviour is to have a list of APN like:
Telefonica (active by default)
Jazztel Internet
Movistar

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

Are there differences other than the APN name?

Comment 2

[Beatriz Rodríguez [:brg]]

The identifier is properly included in APN Editor (see new attachment) but password, proxy host and proxy port are not included (already reported in bug 1061448)

Comment 3

[Beatriz Rodríguez [:brg]]

Attachment: APN Editor

Comment 4

[Beatriz Rodríguez [:brg]]

[Blocking Requested - why for this release]: It was working fine in 2.0. This is a cert. blocker.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

regressionwindow-wanted to find the regressed bug.

Comment 6

[Beatriz Rodríguez [:brg]]

I guess this was caused after the new UX refresh landed in APN settings (bug 1032629)

Comment 7

[howie [:howie]]

Triage: regression, blocking.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/23762

EJ, please check this simple patch when you are back, thanks!

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

There is no environment for testing OMA CP here. Beatriz, could you help check if this patch (and the one for bug 1061448) fix the issue? Thanks!

Comment 10

[Beatriz Rodríguez [:brg]]

Sure! Juanjo will help with the testing/feedback. Moving the ni to him.

Comment 11

[Beatriz Rodríguez [:brg]]

The patch seems not to be working :-(
After receiving the message and install it, the APN list is empty (blank).
Please review your patch and let us know if you need logs or more testing.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

May I know the content of the APN used for testing? Is there any JavaScript error?

Comment 13

[Juanjo Iglesias]

I have tested it using Flame 2.1 (Gecko f816f7e Gaia c7b55ed) with the patch, from the Comment 8, installed. 

The APN list is not empty. Before of the OMA CP message is received, the APN list is created with the APN profiles stored in the phone. After, the profile received via OMA CP is added in this list. 

The new profile received via OMA CP is properly included in the APN list like "Telefonica".

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8484897 [details]
link to https://github.com/mozilla-b2g/gaia/pull/23762

Thanks Arthur, this patch looks good to me. r+.

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks, EJ.

master: bc48cbd9e7b871cc648a525761bd6d512e91d741

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8484897 [details]
link to https://github.com/mozilla-b2g/gaia/pull/23762

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1032629 (APN UX refresh)
[User impact] if declined: Low
[Testing completed]: Manual test completed. Unit tests added.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/5753b75bdd644f0e58536becd702779364340a4b

Comment 18

[Juanjo Iglesias]

I have tested using flame master (Gecko 745dcf1, Gaia 9306e43) and flame v2.1 (Gecko 604fdf4, Gaia 7f738ed), in both case the APN is registered correctly in the APN list. 

After receiving the message and install it, the APN is called by profile name and not by APN name in the list. 

The list include "Telefonica" instead of "telefonica.es", like it is expected.

Comment 19

[Beatriz Rodríguez [:brg]]

Thanks for fixing it. Bug marked as Verified per comment 18.