1061973 - "Remove..." button beside list of websites that are allowed to store data for offline use is disabled

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Botond Ballo [:botond]]

STR:
  1. Go to Edit -> Preferences -> Advanced -> Network.
  2. Select a site from the list "The following websites are allowed
     to store data for offline use:"

Expected results:
  The "Remove..." button beside the list is enabled.

Actual results:
  The "Remove..." button beside the list is disabled.

  However, if you click "Exceptions..." above, close the dialog
  that that opens up without interacting with it, and click on
  an item in the list again, now the "Remove..." button is
  enabled, suggesting that it being disabled before is a bug.

Tested with 2014-09-02 nightly on Linux/KDE.

Comment 1

[Athira S]

Hi I would like to work on this bug.Could someone please guide me to fix this?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Hi Athira,

I don't know this part of the codebase but I can help get you started. The first step as always is to ensure that you have a working build of the Firefox codebase and can reproduce the problem. You can follow the instructions at [1] to get a build up and running. Once you have that working and can reproduce the problem described in comment 0, the next step would be to locate the code responsible. The "Remove" button that is described in comment 0 can be found in the code at [2]. Note that it is initially disabled in the XML, and then the code at [3] is responsible for changing its status dynamically based on what the user selects. So likely the problem is there somewhere, either that function isn't getting triggered or it's not doing the expected thing.

Hopefully that's enough to get you started and somebody else who actually knows this code can chime in. CC'ing :jaws and :Gijs since they should be able to provide more info.

[1] https://developer.mozilla.org/en-US/docs/Simple_Firefox_build
[2] http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/advanced.xul?rev=076b9e5d8208#297
[3] http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/advanced.js?rev=4663c05c869c#488

Comment 3

[Darshana Padmadas]

Hi Karthikaya Gupta,

            I have built nightly 33.0a1 .Now I am trying to find the code where the remove button is disabled.

Comment 4

[Anne (:annevk)]

This is now under "Offline website data" and no longer has this feature as far as I can tell.