1062128 - Open new tab button has no accessible name

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[stsigankov]

Attachment: 1.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20140716183446

Steps to reproduce:

win7

Tried to find the MSAA Name for Open new Tab button.


Actual results:

The name is empty.
Screen attached.


Expected results:

Name should be not empty.
Like it was in previous versions.

Comment 1

[Marco Zehe (:MarcoZ)]

Confirmed. This looks like the tooltiptext got lost for that button at some point. Gijs, can you take a look?

Comment 2

[:Gijs (he/him)]

We dynamically associate tooltips with some buttons now so that we can include the shortcut in the tooltip. So there's no tooltiptext attribute anymore. Marco, what would be a good substitute if we can't bring back the tooltiptext? Should we just use aria-label ?

Comment 3

[Marco Zehe (:MarcoZ)]

How is that dynamic tooltip association done? Are there no tooltip texts any more getting associated to the XUL elements, even though JavaScript? If that's indeed the case, then aria-label is probably the best substitute, yes.

Comment 4

[:Gijs (he/him)]

(In reply to Marco Zehe (:MarcoZ) from comment #3)
> How is that dynamic tooltip association done? Are there no tooltip texts any
> more getting associated to the XUL elements, even though JavaScript? If
> that's indeed the case, then aria-label is probably the best substitute, yes.

Using a tooltip attribute, which has the ID of a tooltip element, whose contents are updated whenever it is shown. So even if the association worked, it'd be wrong half the time :-)

Comment 5

[:Gijs (he/him)]

There should be a label, and after bug 1507365, we should be exposing that label, right Marco/Jamie?

(Also, I could have sworn there was a recent dupe of this bug, but I can't find it now)

Comment 6

[James Teh [:Jamie]]

Heh, remarkable timing that you should ping me on this now. I just spotted this the other day and have been meaning to file a bug.

There is no label at all when the New Tab button is displayed inline in the tab strip:
https://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser.xml#92

92              <xul:toolbarbutton class="tabs-newtab-button toolbarbutton-1"
93                                 anonid="tabs-newtab-button"
94                                 command="cmd_newNavigatorTab"
95                                 onclick="checkForMiddleClick(this, event);"
96                                 tooltip="dynamic-shortcut-tooltip"/>

so bug 1507365 doesn't fix this. This is essentially the same situation as bug 1480415 comment 3.

Note that there is also another New Tab button which can be displayed outside of the tab strip:
https://searchfox.org/mozilla-central/source/browser/base/content/browser.xul#780
From what I can gather, this is used if the New Tab button is moved such that it isn't adjacent to the tabs. This one *does* have a label:

                           label="&tabCmd.label;"

However, this isn't the button that gets used in the default configuration.

Comment 7

[Marco Zehe (:MarcoZ)]

Jamie has answered it all, clearing NI.

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1062128 - set tooltiptext for new tab button directly for a11y reasons, r?johannh

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a002d2b3408b
set tooltiptext for new tab button directly for a11y reasons, r=johannh

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a002d2b3408b

Comment 11

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

I have reproduced this issue with 35.0a1 on Windows 10x64 with NVDA reader.

Confirming this issue as verified fixed on Windows 10x64 and macOS 10.12 on the last Beta 65.0b12 and latest Nightly 66.0a1 (2019-01-20)