1062189 - Layout problems in contact list (was Images in the contacts list are shifted to the right, overlapping letter shortcuts)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This bug is a simple CSS fix that impacts user experience in contacts a lot, and should make it into 2.1.

Comment 2

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github PR

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: identifiable UI flaw. refer to below screenshot.
https://bug1061945.bugzilla.mozilla.org/attachment.cgi?id=8483702

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Sorry for the late point.

Description of this bug was incomplete. We had some problems with the layout of the list, (shifting images to the right), but also with the top of the list.

I'm changing the description for this.

Sorry again for the late advice

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8483576 [details] [review]
Github PR

Could we fix here the fact that the list it self is to close to the top (contacts search).

In the case of favourites you could even see how the icon is cut in the top. For normal letters you'll see as well how the fixed header with the letter is as well pretty close to the search.

Comment 8

[Jason Smith [:jsmith]]

Can you include example STR to generate this bug?

Comment 9

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Francisco, I updated the list separation between the search box and the list.

Comment 10

[Fang Shih [:fang]]

Attachment: ice contact.png

Hi Sergi, 
I also have same problem for ICE contacts. The icon is pretty close to the search bar as well. I hope we can have some space between the icon and the search bar like the spec I attached. Is this something can be fixed at here? 
Thanks!

Comment 11

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Screenshot

Hi Fang,

It looks good to me, check the attachment I just added. Maybe Francisco can confirm about the space being correct. In case it is, do you give a green light to let this one in?

Thanks,
Sergi

Comment 12

[Fang Shih [:fang]]

(In reply to Sergi Mansilla [:sergi] (Telenor) from comment #11)
> Created attachment 8487072 [details]
> Screenshot
> 
> Hi Fang,
> 
> It looks good to me, check the attachment I just added. Maybe Francisco can
> confirm about the space being correct. In case it is, do you give a green
> light to let this one in?
> 
> Thanks,
> Sergi

Wow! looks great!! Thanks!!

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8483576 [details] [review]
Github PR

Hi Sergi,

still can see the start image pretty close to the top:

http://imgur.com/3OAFbpo

Also, could you rebase the patch to have the ICE group in the top?

Thanks!

Comment 14

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 8483576 [details] [review]
Github PR

Solved the favorites header space and rebased to latest master

Comment 15

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8483576 [details] [review]
Github PR

Perfect, thanks a lot for the changes.

Only thing before merging is that the linter job is red :( ... but cannot see anything why it should be tbh.

Comment 16

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Merged at 9cfd2a4278a9a4f56c11c5de25a79f89862ad001

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.1 approval on this when you get a chance.

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8483576 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Feature landed
[User impact] if declined:
Horrible user experience, completely broken in contact list with images
[Testing completed]:
Smoke test passed
[Risk to taking this patch] (and alternatives if risky):
Pretty low, just modifying 2 lines of css
[String changes made]:

Comment 19

[bhavana bajaj [:bajaj]]

Comment on attachment 8483576 [details] [review]
Github PR

low risk css change fixing a 2.1 regression.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/f2e27b2f8ddf262cdf79717495ca661ac86508f9

Comment 21

[Loli (:lolimartinezcr)]

Tested and working
2.2
Flame 
User
Gecko-5cf7098
Gaia-700f481

2.1
Flame
User
Gecko-5cf7098
Gaia-700f481

Comment 22

[Sue]

Attachment: verify_screenshot

This issue can't repro on Flame 2.1
See attachment: verify_screenshot.png
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152
Build-ID        20141118001204
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141118.035447
FW-Date         Tue Nov 18 03:54:58 EST 2014
Bootloader      L1TC00011880