1062197 - Fix hardcoded strings in Messaging settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Théo Chevalier]

Attachment: Flame 2.2

Two strings are displayed in English in Messaging settings:

"SIM settings" (Header)
"Info not available"

Attaching a PR to fix it. We already have the strings, just need to fix the template.

Comment 1

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23668

Evelyn, if you could give a quick review to this one as well… Thanks! :)

Comment 2

[Evelyn Hung]

Comment on attachment 8483367 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23668

oh man, we should really fix bug 928740 to avoid this kind of trivial issue happens again... anyway, thank you for taking care of this. :)

Comment 3

[Théo Chevalier]

Unfortunately, not going to happen anytime soon, our best friend in the meantime is still Accented English :)

[Blocking Requested - why for this release]:

Two unlocalized strings in Messaging settings, bad user experience.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/f17f9a6bd846acb2c01777662bac8647a55f2102

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Théo, please set approval flag on the patch?

Comment 6

[Théo Chevalier]

I got fooled by the string in HTML, the real string is "SIM {{index}} Settings", so right now it doesn't work, we need to give it the SIM number.

I'll attach a follow up PR (or I should open a follow up bug? But that sounds a lot of paperwork for such a trivial issue…)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Note that due to recent policy changes, all patches need approval for uplift regardless of blocking status. Please request Gaia v2.1 approval on this patch when you get a chance. Sorry for the inconvenience :(

Comment 8

[Théo Chevalier]

Attachment: (follow up) Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23741/files

Follow up, the variable was not properly replaced because of a bad selector.

Tested on Flame 2.2, sorry I didn't catch that earlier :/

I'd say we can land this one on master then both on 2.1

Comment 9

[Théo Chevalier]

Attachment: Patched 2.2

Comment 10

[Théo Chevalier]

Comment on attachment 8483367 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23668

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1001285
[User impact] if declined: English strings in Messaging settings for all users
[Testing completed]: Tested on Flame device on 2.2
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none

Comment 11

[Théo Chevalier]

Comment on attachment 8484529 [details]
(follow up) Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23741/files

[Approval Request Comment]
Same as for previous PR, follow up

Comment 12

[Théo Chevalier]

Thanks Evelyn, setting checkin-needed for the follow up

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/cfebf6a90fbdf687c876d4717169b72a86d0386a

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/0d8bf6d56287f9e192e6f11911e448e4955a3829
v2.1: https://github.com/mozilla-b2g/gaia/commit/75e26a51da368d4c81a02fd5c8198603f040d446

Comment 16

[Brogan Zumwalt [Inactive]]

Unable to verify this issue as we do not have SIM Card that has unknown SMSC state. This makes it impossible to verify the string "Info Not Available" is properly translated.

Comment 17

[SandKing]

Hi Josh,
This issue has been verified successfully on Flame2.1
See video: "verify_1062197.MP4".

Flame2.1 build:
Gaia-Rev        afdfa629be209dd53a1b7b6d6c95eab7077ffcd9
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/dc3018cbdbe6
Build-ID        20141123001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141123.035029
FW-Date         Sun Nov 23 03:50:40 EST 2014
Bootloader      L1TC00011880

Comment 18

[SandKing]

Attachment: Verify Bug: verify_1062197.mp4