Closed
Bug 1062371
Opened 10 years ago
Closed 10 years ago
Autophone - incorporate recent changes to mozdevice.adb
Categories
(Testing Graveyard :: Autophone, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(6 files)
|
11.21 KB,
patch
|
Details | Diff | Splinter Review | |
|
5.06 KB,
patch
|
Details | Diff | Splinter Review | |
|
8.28 KB,
patch
|
Details | Diff | Splinter Review | |
|
7.85 KB,
patch
|
Details | Diff | Splinter Review | |
|
2.37 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.40 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
jgraham has recently landed several changes to adb.py in mozdevice which need to be incorporated. There are several minor changes which need to be made to Autophone due to changes in method signatures.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
has a trailing whitespace error on line 86 which we'll fix up in a later bug.
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
|
Assignee | |
Comment 6•10 years ago
|
||
This applies on top of the patch in bug 1063886.
Attachment #8485679 -
Flags: review?(mcote)
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8485679 [details] [diff] [review] bug-1062371.patch Review of attachment 8485679 [details] [diff] [review]: ----------------------------------------------------------------- ::: phonetest.py @@ +71,3 @@ > logger_name='autophone.phonetest.adb', > device_ready_retry_wait=self.options.device_ready_retry_wait, > + device_ready_retry_attempts=self.options.device_ready_retry_attempts, Weird indenting. ::: worker.py @@ +181,3 @@ > logger_name='autophone.worker.adb', > device_ready_retry_wait=self.options.device_ready_retry_wait, > + device_ready_retry_attempts=self.options.device_ready_retry_attempts, Weird indenting.
Attachment #8485679 -
Flags: review?(mcote) → review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
https://github.com/mozilla/autophone/commit/e57567dcece5b56d670b335749704c606403d4e2 https://github.com/mozilla/autophone/commit/5ca1fb7cb37f9bee6919405664a0e0e46c843c19 https://github.com/mozilla/autophone/commit/dcb8f8c878eb333c7cafd5798f4fb65bbcfb0af5 https://github.com/mozilla/autophone/commit/1c7cb1e2ed39eb7a9089bb5db746d91466bc4588 https://github.com/mozilla/autophone/commit/6682c94252690cccca3c2a89fc35481b3608efd0 https://github.com/mozilla/autophone/commit/ff8bc7b037c74f85b8151236649f2976fde19185
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•