1062555 - "avast! Online Security" add-on does not work with e10s

Status: RESOLVED INCOMPLETE

(Firefox :: Extension Compatibility, defect)

Description

[u279076]

The add-on installs okay but does not appear to function. Whenever I click the button in the toolbar I see nothing happen. Checking browser console reveals "TypeError: window is null". In a non-e10s browser, clicking this button displays an overlay.

Comment 1

[Chris Peterson [:cpeterson]]

hi Martin, are you the maintainer of avast's Firefox add-on?

It does not seem to be compatible with multi-process Firefox (e10s). If you have any questions about e10s support, just drop by the #e10s IRC channel on irc.mozilla.org. MDN also has a good introduction:

https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

Comment 2

[u279076]

My apologies, what I actually tested was the AMO version of avast!, v9.0.2022.113, not the Beta as originally indicated. Sorry about that. If you can point me to the Beta version I'll be happy to test it.

Comment 3

[Allison Naaktgeboren :ally]

Is this a binary addon?

Comment 4

[u279076]

(In reply to :ally Allison Naaktgeboren from comment #3)
> Is this a binary addon?

I don't know.

Comment 5

[Chris Peterson [:cpeterson]]

avast!'s website does not have a straightforward way to report bugs, so I tweeted about this bug to @avast_antivirus, the company's Twitter account.

Comment 6

[Martin Havelka]

Hi Anthon and Chris,

thank you for your notification re. the E10s and pointing us to detailed resources. We started to look at what changes are required in the Avast add-on.
Thank you.

Comment 7

[Tracy Walker [:tracy]]

Assignee: :tracy
Link to add-on: https://www.avast.com (this a pay for use security suite)
Contact info for add-on: [e-mail]
Bug #: this bug 1062555
Add-on ID: unknown
How well does it work?: Reporter says it installs but doesn't function.
Steps to reproduce broken features:
see https://bugzilla.mozilla.org/show_bug.cgi?id=1062555#c0
Any obvious performance problems? unknown
Chromium version: yes - https://chrome.google.com/webstore/detail/avast-online-security/gomekmidlodglbbmalcneegieacbdmki

Comment 8

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Anthony, how did you manage to get a copy of this add-on?

Comment 9

[u279076]

(In reply to Bill McCloskey (:billm) from comment #8)
> Anthony, how did you manage to get a copy of this add-on?

The version I tested originally was one hosted on AMO. I was never able to get my hands on an add-on directly from Avast!.

Comment 10

[u279076]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #9)
> The version I tested originally was one hosted on AMO. I was never able to
> get my hands on an add-on directly from Avast!.

I double checked and the Avast! add-on that I tested above from AMO is no longer on AMO. I suppose this add-on no longer exists in any meaningful way, unless Avast! can provide a copy of their add-on to us for testing.

Comment 11

[Martin Havelka]

Hello Anthony,

The add-on exists, we just disabled it on AOM. We will re-enable it there soon with new version. We also have new version in the queue that should resolve e10s compatibility issues. What is the best way to provide you with the our testing version?

Thank you,
Martin

Comment 12

[u279076]

(In reply to Martin Havelka from comment #11)
> What is the best way to provide you with the our testing version?

I'll send you an email off this bug report to coordinate.

Comment 13

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Anthony, can you let me know how this goes? Thanks.

Comment 14

[u279076]

(In reply to Bill McCloskey (:billm) from comment #13)
> Anthony, can you let me know how this goes? Thanks.

Will do. I've been told the add-on is still WIP. I'll keep the needinfo flag set and report back when I have something to report.

Comment 15

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Any progress here?

Comment 16

[u279076]

(In reply to Bill McCloskey (:billm) from comment #15)
> Any progress here?

Sorry I'm still waiting for a version of the add-on to test.

Comment 17

[Karl Dubost💡 :karlcow]

Martin,

No answer to the first email studenyp@ is an unknown user. Havelkam didn't reply
Any information about the status?

Comment 18

[Karl Dubost💡 :karlcow]

Received an answer from Martin. Following up to ask for status.

I also gave him the following info:

> They start every Tuesday at 10 am UTC and go on for 17 hours, 
> see http://atsay.github.io/e10s_office_hours/
> 
> There is also #e10s on IRC

Comment 19

[Bob Silverberg [:bsilverberg]]

Avast Online Security is on our list of popular Chrome extensions that we will attempt to enable to run in Firefox as a web extension. If we are successful that may eliminate the need to fix the existing add-on to work with e10s. I will add the bug for enabling the extension as a dependency to this bug after I open it.

Comment 20

[Firefox Bug Husbandry Bot]

With Firefox 57 only WebExtensions are permitted and are, by default, e10s compatible.