Closed Bug 1062919 Opened 10 years ago Closed 10 years ago

Skia masking code is not great

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jrmuizel, Unassigned)

References

Details

This:
                __m128i src_scale_wide =  _mm_set_epi8(0, *(mask+3),\
                                0, *(mask+3),0, \
                                *(mask+2),0, *(mask+2),\
                                0,*(mask+1), 0,*(mask+1),\
                                0, *mask,0,*mask);

seems to generate bad code on all the compilers that I checked.
This has been fixed upstream:

https://skia.googlesource.com/skia.git/+/60e4ad7b29f50ebd7698d2d37580d5c8da5ce600
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.