1063359 - Firefox fails to run with GTK3, in the presence of --as-needed, with "libxul.so: undefined symbol: gtk_main_do_event"

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Jan Alexander Steffens [:heftig]]

If LDFLAGS contains -Wl,--as-needed and Firefox 34.0a2 is configured with GTK3 widgets, xpcshell fails during the build, complaining about a symbol lookup error in libxul.so:

/tmp/mozilla-central/obj-x86_64-unknown-linux-gnu/dist/bin/xpcshell: symbol lookup error: /tmp/mozilla-central/obj-x86_64-unknown-linux-gnu/dist/bin/libxul.so: undefined symbol: gtk_main_do_event

Without --as-needed, libxul.so directly depends on libgtk-3.so.0, breaking the plugin-container (bug 1051209).

Comment 1

[Jan Alexander Steffens [:heftig]]

A common cause for this problem is misordering the libs on the ld command line. If lib A depends on lib B, lib A must be first on the command line, otherwise ld with --as-needed skips lib B as nothing depends on it.

Comment 2

[Jan Alexander Steffens [:heftig]]

Ah, my builds might trigger this bug because my LDFLAGS don't contain a literal "-Wl,--as-needed" (the build system checks for that), but the --as-needed is part of a longer -Wl, specifically "-Wl,-O1,--sort-common,--as-needed,-z,relro"

Comment 3

[Daniel Holbert [:dholbert]]

Just got a report on IRC of a gtk3-enabled build *building* successfully, but failing to *run*, with the same issue from comment 0 ("libxul.so: undefined symbol: gtk_main_do_event").  Marking as "confirmed" based on that report.

(I think comment 0 is really a failure to *run*, not a failure to *build*. Even though it's part of the build process, if we're starting xpcshell & libxul, then we've already built gecko. Hence, generalizing summary to be about running instead of building.)

Comment 4

[Mike Hommey [:glandium]]

(In reply to Jan Steffens from comment #2)
> Ah, my builds might trigger this bug because my LDFLAGS don't contain a
> literal "-Wl,--as-needed" (the build system checks for that), but the
> --as-needed is part of a longer -Wl, specifically
> "-Wl,-O1,--sort-common,--as-needed,-z,relro"

Yes, the build system looks for an independent -Wl,--as-needed in LDFLAGS to trigger using -Wl,--no-as-needed "appropriately".

Comment 5

[Jeff Muizelaar [:jrmuizel]]

I'm running into this in Ubuntu 15.04 and it looks like gcc is adding -Wl,--as-needed by default. Can we just unconditionally add -Wl,--no-as-needed?

Comment 6

[Mike Hommey [:glandium]]

We'd need to detect what the linker uses by default. Because -Wl,--no-as-needed affects all the following linked libraries, including those the compiler adds on its own. So the -Wl,--no-as-needed -llib -Wl,--as-needed pattern is needed, but then that would make all following libraries linked "as-needed" on no-as-needed builds.

Or, we could just force -Wl,--as-needed on all our builds.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Unconditionally use -Wl,--no-as-needed when building with GNU ld/gold

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/738d8ee106fe

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a052bbea7c2e

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/738d8ee106fe

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a052bbea7c2e